diff options
| author | Eugene Burmako <xeno.by@gmail.com> | 2014-01-30 09:40:22 +0300 |
|---|---|---|
| committer | Eugene Burmako <xeno.by@gmail.com> | 2014-02-14 23:51:21 +0100 |
| commit | 012ad093a68c08f6962f2fb282a0be43c10e988d (patch) | |
| tree | 0215e4ea2dbaa3b9496608a36d9039264777b4f6 | |
| parent | f14e9fe5eda611798d95955620b3e653a2991475 (diff) | |
| download | scala-012ad093a68c08f6962f2fb282a0be43c10e988d.tar.gz scala-012ad093a68c08f6962f2fb282a0be43c10e988d.tar.bz2 scala-012ad093a68c08f6962f2fb282a0be43c10e988d.zip | |
deprecates api#Name.decoded and api#Name.encoded
Presence of both decoded/encoded and decodedName/encodedName has always
baffled me, as one of those method groups is clearly redundant, and
this pull request presents a great opportunity to address this by
deprecating one of the groups.
After some deliberation, I’ve chosen decoded/encoded as the deprecation
target, because its derivation from decodedName/encodedName is easier
than the other way around.
| -rw-r--r-- | src/reflect/scala/reflect/api/Names.scala | 2 | ||||
| -rw-r--r-- | test/files/run/t6323b.scala | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/src/reflect/scala/reflect/api/Names.scala b/src/reflect/scala/reflect/api/Names.scala index 30c512ab64..fe5f47c25d 100644 --- a/src/reflect/scala/reflect/api/Names.scala +++ b/src/reflect/scala/reflect/api/Names.scala @@ -87,11 +87,13 @@ trait Names { /** Replaces all occurrences of \$op_names in this name by corresponding operator symbols. * Example: `foo_\$plus\$eq` becomes `foo_+=` */ + @deprecated("Use `decodedName.toString` instead", "2.11.0") def decoded: String /** Replaces all occurrences of operator symbols in this name by corresponding \$op_names. * Example: `foo_+=` becomes `foo_\$plus\$eq`. */ + @deprecated("Use `encodedName.toString` instead", "2.11.0") def encoded: String /** The decoded name, still represented as a name. diff --git a/test/files/run/t6323b.scala b/test/files/run/t6323b.scala index f530ac3ecc..50d0900c7f 100644 --- a/test/files/run/t6323b.scala +++ b/test/files/run/t6323b.scala @@ -10,7 +10,7 @@ object Test extends App { val lookAtMe = m.reflect(Test("a",List(5))) val value = u.weakTypeOf[Test] val members = value.members - val member = value.members.filter(_.name.encoded == "a") + val member = value.members.filter(_.name.encodedName == TermName("a")) val aAccessor = lookAtMe.reflectMethod(member.head.asMethod) val thisShouldBeA = aAccessor.apply() println(thisShouldBeA) |