Restore binary compatiblity with 2.12.0

  - Revert a typo fix to a non-private method
  - Whitelist changes to internals of runtime reflection that
    are not part of the API and should only be referenced from
    within scala-reflect.jar itself.

1 files changed, 5 insertions, 209 deletions

diff --git a/bincompat-backward.whitelist.conf b/bincompat-backward.whitelist.conf
index 637bd586e0..bb94f4be6c 100644
--- a/bincompat-backward.whitelist.conf
+++ b/bincompat-backward.whitelist.conf
@@ -5,218 +5,14 @@ filter {
     # "scala.reflect.runtime"
   ]
   problems=[
-    // see SI-8372
     {
-        matchName="scala.collection.mutable.ArrayOps#ofChar.unzip"
-        problemName=IncompatibleMethTypeProblem
+      matchName="scala.reflect.runtime.JavaMirrors#JavaMirror.unpickleClass"
+      problemName=IncompatibleMethTypeProblem
     },
     {
-        matchName="scala.collection.mutable.ArrayOps#ofChar.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofByte.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofByte.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofShort.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofShort.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofLong.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofLong.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofInt.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofInt.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps.unzip"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps.unzip3"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps.unzip"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps.unzip3"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofFloat.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofFloat.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofBoolean.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofBoolean.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofRef.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofRef.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofUnit.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofUnit.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofDouble.unzip"
-        problemName=IncompatibleMethTypeProblem
-    },
-    {
-        matchName="scala.collection.mutable.ArrayOps#ofDouble.unzip3"
-        problemName=IncompatibleMethTypeProblem
-    },
-    // see SI-8200
-    {
-        matchName="scala.reflect.api.StandardLiftables#StandardLiftableInstances.liftTree"
-        problemName=MissingMethodProblem
-    },
-    // see SI-8331
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi#SyntacticTypeAppliedExtractor.unapply"
-        problemName=IncompatibleResultTypeProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi#SyntacticTypeAppliedExtractor.unapply"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticSelectType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticAppliedType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticSelectTerm"
-        problemName=MissingMethodProblem
-    },
-    // see SI-8366
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticPartialFunction"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Mirror.symbolOf"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Mirror.typeOf"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Mirror.weakTypeOf"
-        problemName=MissingMethodProblem
-    },
-    // see SI-8388
-    {
-        matchName="scala.reflect.api.Internals$ReificationSupportApi$SyntacticIdentExtractor"
-        problemName=MissingClassProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticIdent"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticSingletonType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticTermIdent"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticTypeIdent"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticCompoundType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticAnnotatedType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticTypeProjection"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.api.Internals#ReificationSupportApi.SyntacticExistentialType"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.reflect.runtime.SynchronizedOps.newNestedScope"
-        problemName=MissingMethodProblem
-    },
-    // see github.com/scala/scala/pull/3925, SI-8627, SI-6440
-    {
-        matchName="scala.collection.TraversableLike.filterImpl"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.immutable.Stream.filteredTail"
-        problemName=MissingMethodProblem
-    },
-    // https://github.com/scala/scala/pull/3848 -- SI-8680
-    {
-        matchName="scala.collection.immutable.Stream.scala$collection$immutable$Stream$$loop$6"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.immutable.Stream.scala$collection$immutable$Stream$$loop$5"
-        problemName=MissingMethodProblem
-    },
-    {
-        matchName="scala.collection.immutable.Stream.scala$collection$immutable$Stream$$loop$4"
-        problemName=MissingMethodProblem
-    },
-    // SI-8946
-    {
-        matchName="scala.reflect.runtime.ThreadLocalStorage#MyThreadLocalStorage.values"
-        problemName=MissingMethodProblem
-    },
-    // the below method was the unused private (sic!) method but the compatibility checker was complaining about it
-    {
-        matchName="scala.reflect.io.ZipArchive.scala$reflect$io$ZipArchive$$walkIterator"
-        problemName=MissingMethodProblem
+      matchName="scala.reflect.runtime.SymbolLoaders#TopClassCompleter.this"
+      problemName=IncompatibleMethTypeProblem
     }
+
   ]
 }