diff options
| author | Jason Zaugg <jzaugg@gmail.com> | 2016-11-16 15:45:44 +1000 |
|---|---|---|
| committer | Jason Zaugg <jzaugg@gmail.com> | 2016-11-16 16:33:19 +1000 |
| commit | 98c1f107caad5d5d558e33837023e55b71bb59ea (patch) | |
| tree | 717ccce3e9f79777e9a45dee4a7a2ac3fa46c586 /project | |
| parent | 24043cab73ab99b39a1c5ed83a73f54ba41b2324 (diff) | |
| download | scala-98c1f107caad5d5d558e33837023e55b71bb59ea.tar.gz scala-98c1f107caad5d5d558e33837023e55b71bb59ea.tar.bz2 scala-98c1f107caad5d5d558e33837023e55b71bb59ea.zip | |
Workaround a bug that rendered MiMa inoperative
MiMa has been off-duty because of a bug in handling the default
value of the new paramter `--direction`.
This commit explicitly provides this parameter to get things
working again post haste.
Fixes scala/scala-dev#264
Diffstat (limited to 'project')
| -rw-r--r-- | project/MiMa.scala | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/project/MiMa.scala b/project/MiMa.scala index 6c6f5efd51..8963699c17 100644 --- a/project/MiMa.scala +++ b/project/MiMa.scala @@ -24,7 +24,7 @@ object MiMa { def runOnce(prev: java.io.File, curr: java.io.File, isForward: Boolean): Unit = { val direction = if (isForward) "forward" else "backward" log.info(s"Checking $direction binary compatibility") - log.debug(s"prev = $prev, curr = $curr") + log.info(s"prev = $prev, curr = $curr") runMima( prev = if (isForward) curr else prev, curr = if (isForward) prev else curr, @@ -48,7 +48,11 @@ object MiMa { "--prev", prev.getAbsolutePath, "--curr", curr.getAbsolutePath, "--filters", filter.getAbsolutePath, - "--generate-filters" + "--generate-filters", + // !!! Command line MiMa (which we call rathan the SBT Plugin for reasons alluded to in f2d0f1e85) incorrectly + // defaults to no checking (!) if this isn't specified. Fixed in https://github.com/typesafehub/migration-manager/pull/138 + // TODO: Try out the new "--direction both" mode of MiMa + "--direction", "backwards" ) val exitCode = TrapExit(com.typesafe.tools.mima.cli.Main.main(args), log) if (exitCode != 0) |