Reflection toolboxes now respect settings that ...

Reflection toolboxes now respect settings that are provided to them.

Before the fix CompilerCommand lacked the (args, settings, errorFn)
ctor. I added it and provided means to augment passed settings with
custom errorFn.

Closes SI-5239. Review by odersky.

1 files changed, 7 insertions, 1 deletions

diff --git a/src/compiler/scala/reflect/runtime/ToolBoxes.scala b/src/compiler/scala/reflect/runtime/ToolBoxes.scala
index 7ec7d15fb7..e617239398 100644
--- a/src/compiler/scala/reflect/runtime/ToolBoxes.scala
+++ b/src/compiler/scala/reflect/runtime/ToolBoxes.scala
@@ -3,6 +3,7 @@ package runtime
 
 import scala.tools.nsc.reporters.Reporter
 import scala.tools.nsc.reporters.StoreReporter
+import scala.tools.nsc.reporters.AbstractReporter
 import scala.tools.nsc.ReflectGlobal
 import scala.tools.nsc.CompilerCommand
 import scala.tools.nsc.Global
@@ -109,7 +110,12 @@ trait ToolBoxes extends { self: Universe =>
       }
 
     lazy val compiler: ToolBoxGlobal = {
-      val command = new CompilerCommand(arguments.toList, reporter.error(scala.tools.nsc.util.NoPosition, _))
+      val errorFn: String => Unit = reporter.error(scala.tools.nsc.util.NoPosition, _)
+      val command = reporter match {
+        case reporter: AbstractReporter => new CompilerCommand(arguments.toList, reporter.settings, errorFn)
+        case _ => new CompilerCommand(arguments.toList, errorFn)
+      }
+
       command.settings.outputDirs setSingleOutput virtualDirectory
       new ToolBoxGlobal(command.settings, reporter)
     }