diff options
author | Paul Phillips <paulp@improving.org> | 2010-03-25 19:55:53 +0000 |
---|---|---|
committer | Paul Phillips <paulp@improving.org> | 2010-03-25 19:55:53 +0000 |
commit | 6ee24a3c5d31ef769e47410d8806a5f4bd7a06bf (patch) | |
tree | e0e5352fba603060439c6fe9e1d024192eb32bd5 /src/compiler/scala/tools/ant/sabbus | |
parent | c0b615fe80fd052d5c87f39cfa6626da43c03669 (diff) | |
download | scala-6ee24a3c5d31ef769e47410d8806a5f4bd7a06bf.tar.gz scala-6ee24a3c5d31ef769e47410d8806a5f4bd7a06bf.tar.bz2 scala-6ee24a3c5d31ef769e47410d8806a5f4bd7a06bf.zip |
While working on partest discovered that Compil...
While working on partest discovered that CompilerCommand ignores half
its constructor arguments and a couple dozen places blithely pass it
those arguments as if they're being used. Then there were setups like
this:
class OfflineCompilerCommand(
arguments: List[String],
settings: Settings,
error: String => Unit,
interactive: Boolean)
extends CompilerCommand(arguments, new Settings(error), error, false)
Hey offline compiler command, why throw away the perfectly good settings
you were given? Ever heard 'reduce, reuse, recycle'? How did you ever
work... or do you? No review.
Diffstat (limited to 'src/compiler/scala/tools/ant/sabbus')
-rw-r--r-- | src/compiler/scala/tools/ant/sabbus/ForeignCompiler.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/compiler/scala/tools/ant/sabbus/ForeignCompiler.scala b/src/compiler/scala/tools/ant/sabbus/ForeignCompiler.scala index 543ea10cc7..2263196af4 100644 --- a/src/compiler/scala/tools/ant/sabbus/ForeignCompiler.scala +++ b/src/compiler/scala/tools/ant/sabbus/ForeignCompiler.scala @@ -32,7 +32,7 @@ class ForeignCompiler { private lazy val nsc: Global = { try { - val command = new CompilerCommand(args.toList, settings, error, false) + val command = new CompilerCommand(args.toList, settings) new Global(command.settings, reporter) } catch { @@ -42,7 +42,7 @@ class ForeignCompiler { } def compile(files: Array[File]): Int = { - val command = new CompilerCommand(files.toList.map(_.toString), settings, error, true) + val command = new CompilerCommand(files.toList map (_.toString), settings) (new nsc.Run) compile command.files reporter.ERROR.count << 16 | reporter.WARNING.count } |