corrected several problems with error reporting...

corrected several problems with error reporting: positions checked
twice, warnings masking errors. Refined solution of forward implicits
without5 result type.

1 files changed, 3 insertions, 15 deletions

diff --git a/src/compiler/scala/tools/nsc/CompilationUnits.scala b/src/compiler/scala/tools/nsc/CompilationUnits.scala
index f536a16a62..bf02e114ab 100644
--- a/src/compiler/scala/tools/nsc/CompilationUnits.scala
+++ b/src/compiler/scala/tools/nsc/CompilationUnits.scala
@@ -44,19 +44,11 @@ trait CompilationUnits { self: Global =>
      */
     val icode: HashSet[icodes.IClass] = new HashSet
 
-    val errorPositions = new HashSet[Position]
-
     def error(pos: Position, msg: String) =
-      if (inIDE || !(errorPositions contains pos)) {
-        if (!inIDE) errorPositions += pos
-        reporter.error((pos), msg)
-      }
+      reporter.error(pos, msg)
 
     def warning(pos: Position, msg: String) =
-      if (inIDE || !(errorPositions contains pos)) {
-        if (!inIDE) errorPositions += pos
-        reporter.warning((pos), msg)
-      }
+      reporter.warning(pos, msg)
 
     def deprecationWarning(pos: Position, msg: String) =
       if (settings.deprecation.value) warning(pos, msg)
@@ -67,10 +59,7 @@ trait CompilationUnits { self: Global =>
       else currentRun.uncheckedWarnings = true
 
     def incompleteInputError(pos: Position, msg:String) =
-      if (inIDE || !(errorPositions contains pos)) {
-        if (!inIDE) errorPositions += pos
-        reporter.incompleteInputError((pos), msg)
-      }
+      reporter.incompleteInputError(pos, msg)
 
     /** Is this about a .java source file? */
     lazy val isJava = source.file.name.endsWith(".java")
@@ -81,7 +70,6 @@ trait CompilationUnits { self: Global =>
       fresh = null
       body = null
       depends.clear
-      errorPositions.clear
       defined.clear
     }
   }