No warn when discarding r.f(): r.type

The paradigm is `def add(x: X): Unit = listBuffer += x`.

The value that is discarded is not new information.

Also cleans up the recent tweaks to help messaging.

Adds newlines in case they ask for multiple helps.

1 files changed, 1 insertions, 9 deletions

diff --git a/src/compiler/scala/tools/nsc/CompilerCommand.scala b/src/compiler/scala/tools/nsc/CompilerCommand.scala
index 3879d7b425..24da6ba487 100644
--- a/src/compiler/scala/tools/nsc/CompilerCommand.scala
+++ b/src/compiler/scala/tools/nsc/CompilerCommand.scala
@@ -103,15 +103,7 @@ class CompilerCommand(arguments: List[String], val settings: Settings) {
       val components = global.phaseNames  // global.phaseDescriptors // one initializes
       s"Phase graph of ${components.size} components output to ${genPhaseGraph.value}*.dot."
     }
-    // would be nicer if we could ask all the options for their helpful messages
-    else {
-      val sb = new StringBuilder
-      allSettings foreach {
-        case s if s.isHelping => sb append s.help
-        case _ =>
-      }
-      sb.toString
-    }
+    else allSettings.filter(_.isHelping).map(_.help).mkString("\n\n")
   }
 
   /**