I wrote a warning when nullary methods return U...

I wrote a warning when nullary methods return Unit. I wimped out of
including it in this patch because we had about 200 of them, and that's
what is fixed in this patch. I will add the warning to some kind of
"-Xlint" feature after 2.9.

This is motivated at least partly by the resolution of #4506, which
indicates the distinction between "def foo()" and "def foo" will
continue to jab its pointy stick into our eyes, so I believe we have a
minimal duty of at least following our own advice about what they mean
and not making a semirandom choice as to whether a method has parens or
not. Review by community.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/compiler/scala/tools/nsc/backend/icode/Members.scala b/src/compiler/scala/tools/nsc/backend/icode/Members.scala
index 69258c9ecb..92107565f9 100644
--- a/src/compiler/scala/tools/nsc/backend/icode/Members.scala
+++ b/src/compiler/scala/tools/nsc/backend/icode/Members.scala
@@ -198,7 +198,7 @@ trait Members { self: ICodes =>
     override def toString() = symbol.fullName
 
     import opcodes._
-    def checkLocals: Unit = {
+    def checkLocals(): Unit = {
       def localsSet = code.blocks.flatten collect {
         case LOAD_LOCAL(l)  => l
         case STORE_LOCAL(l) => l
@@ -218,7 +218,7 @@ trait Members { self: ICodes =>
      *
      * This method should be most effective after heavy inlining.
      */
-    def normalize: Unit = if (this.code ne null) {
+    def normalize(): Unit = if (this.code ne null) {
       val nextBlock: mutable.Map[BasicBlock, BasicBlock] = mutable.HashMap.empty
       for (b <- code.blocks.toList
         if b.successors.length == 1;
@@ -251,7 +251,7 @@ trait Members { self: ICodes =>
       checkValid(this)
     }
 
-    def dump {
+    def dump() {
       val printer = new TextPrinter(new PrintWriter(Console.out, true),
                                     new DumpLinearizer)
       printer.printMethod(this)