diff options
| author | Iulian Dragos <jaguarul@gmail.com> | 2013-02-01 14:36:14 +0100 |
|---|---|---|
| committer | Iulian Dragos <jaguarul@gmail.com> | 2013-02-01 14:36:14 +0100 |
| commit | a6137d19b6ec7c63fbbae274de3c78e310bba4ae (patch) | |
| tree | d0411389ee939c1beabea1a699d1ed5c354038b6 /src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala | |
| parent | 309ff57ba62b6a6ec1a9c1b28b8bbabfd1b47b72 (diff) | |
| download | scala-a6137d19b6ec7c63fbbae274de3c78e310bba4ae.tar.gz scala-a6137d19b6ec7c63fbbae274de3c78e310bba4ae.tar.bz2 scala-a6137d19b6ec7c63fbbae274de3c78e310bba4ae.zip | |
Fix SI-6578. Deprecated `askType` because of possible race conditions in type checker.
AskType triggers type-checks the given source and returns a typed tree. If that
source is already loaded (a precondition), the background compilation loop may actually
be compiling that same source. The new type checker run may then get into an inconsistent
state and try to add twice the same synthetic members, like `canEqual`.
Most of the times, `askLoadedTyped` (that waits for the type checker to finish, and
returns the most recent typed tree) *is* the right way to go.
Removed occurrences of the deprecated method in tests and interactive.REPL.
@reviewby @huitseeker,@odersky
Diffstat (limited to 'src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala')
| -rw-r--r-- | src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala b/src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala index 62d274bc70..597b9012ce 100644 --- a/src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala +++ b/src/compiler/scala/tools/nsc/interactive/tests/InteractiveTest.scala @@ -55,7 +55,6 @@ abstract class InteractiveTest with AskShutdown with AskReload with AskLoadedTyped - with AskType with PresentationCompilerInstance with CoreTestDefs with InteractiveTestSettings { self => |