diff options
| author | Paul Phillips <paulp@improving.org> | 2012-09-18 00:59:00 -0700 |
|---|---|---|
| committer | Paul Phillips <paulp@improving.org> | 2012-09-18 02:19:12 -0700 |
| commit | 0e061f420f3b6e7447658f003d00f6108fa649e0 (patch) | |
| tree | 0b8593545df932f08b051441112ce2ae2f6804e3 /src/reflect/scala/reflect/internal/Trees.scala | |
| parent | 66603a2c003852d39faec20a9763fb0e25049cf4 (diff) | |
| download | scala-0e061f420f3b6e7447658f003d00f6108fa649e0.tar.gz scala-0e061f420f3b6e7447658f003d00f6108fa649e0.tar.bz2 scala-0e061f420f3b6e7447658f003d00f6108fa649e0.zip | |
Removed many @inline annotations and final modifiers.
It is my belief that these @inlines and finals landed between
unhelpful and harmful. I am sure this will be disputed in some
cases. It's too much and too difficult to measure except in the
aggregate unless we have specific @inline sites to discuss.
I don't know upon whom the burden of proof lies. I think we
should err on the side given here, since there is no evidence
of any consistent rationale being applied and it is easy to
verify the negative impact scala compiler inlining can have on
hotspot's far more sophisticated inlining.
Diffstat (limited to 'src/reflect/scala/reflect/internal/Trees.scala')
| -rw-r--r-- | src/reflect/scala/reflect/internal/Trees.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/reflect/scala/reflect/internal/Trees.scala b/src/reflect/scala/reflect/internal/Trees.scala index 5a6d6ce7c7..6540d4a7c1 100644 --- a/src/reflect/scala/reflect/internal/Trees.scala +++ b/src/reflect/scala/reflect/internal/Trees.scala @@ -21,10 +21,10 @@ trait Trees extends api.Trees { self: SymbolTable => if (Statistics.canEnable) Statistics.incCounter(TreesStats.nodeByType, getClass) - @inline final override def pos: Position = rawatt.pos + final override def pos: Position = rawatt.pos private[this] var rawtpe: Type = _ - @inline final def tpe = rawtpe + final def tpe = rawtpe def tpe_=(t: Type) = rawtpe = t def setType(tp: Type): this.type = { rawtpe = tp; this } def defineType(tp: Type): this.type = setType(tp) |