eagerly initializes lazy vals and objects in runtime reflection

The code to do so is curated with the help of a generator. Because this
needs to inspect code post-typer, the code generator is run during partest
as a code-validator. We could concievably do the same with a macro, but
this approach might be a better starting point which macros continue to
stabilize.

Removes Definitions.AnyRefModule and an already deprecated alias, as
these have been throwing exceptions for more than a year since 6bb5975289.
They used to be used by AnyRef specialization.

4 files changed, 497 insertions, 11 deletions

diff --git a/src/reflect/scala/reflect/internal/Definitions.scala b/src/reflect/scala/reflect/internal/Definitions.scala
index e8fea43758..7b88514429 100644
--- a/src/reflect/scala/reflect/internal/Definitions.scala
+++ b/src/reflect/scala/reflect/internal/Definitions.scala
@@ -289,12 +289,6 @@ trait Definitions extends api.StandardDefinitions {
     lazy val ConstantFalse = ConstantType(Constant(false))
     lazy val ConstantNull  = ConstantType(Constant(null))
 
-    // Note: this is not the type alias AnyRef, it's a companion-like
-    // object used by the @specialize annotation.
-    lazy val AnyRefModule = getMemberModule(ScalaPackageClass, nme.AnyRef)
-    @deprecated("Use AnyRefModule", "2.10.0")
-    def Predef_AnyRef = AnyRefModule
-
     lazy val AnyValClass: ClassSymbol = (ScalaPackageClass.info member tpnme.AnyVal orElse {
       val anyval    = enterNewClass(ScalaPackageClass, tpnme.AnyVal, AnyTpe :: Nil, ABSTRACT)
       val av_constr = anyval.newClassConstructor(NoPosition)
@@ -1193,8 +1187,8 @@ trait Definitions extends api.StandardDefinitions {
       }
     }
 
-    private def fatalMissingSymbol(owner: Symbol, name: Name, what: String = "member") = {
-      throw new FatalError(owner + " does not have a " + what + " " + name)
+    private def fatalMissingSymbol(owner: Symbol, name: Name, what: String = "member", addendum: String = "") = {
+      throw new FatalError(owner + " does not have a " + what + " " + name + addendum)
     }
 
     def getLanguageFeature(name: String, owner: Symbol = languageFeatureModule): Symbol = getMember(owner, newTypeName(name))
@@ -1229,7 +1223,8 @@ trait Definitions extends api.StandardDefinitions {
     def getMemberModule(owner: Symbol, name: Name): ModuleSymbol = {
       getMember(owner, name.toTermName) match {
         case x: ModuleSymbol => x
-        case _               => fatalMissingSymbol(owner, name, "member object")
+        case NoSymbol        => fatalMissingSymbol(owner, name, "member object")
+        case other           => fatalMissingSymbol(owner, name, "member object", addendum = s". A symbol ${other} of kind ${other.accurateKindString} already exists.")
       }
     }
     def getTypeMember(owner: Symbol, name: Name): TypeSymbol = {
diff --git a/src/reflect/scala/reflect/internal/Symbols.scala b/src/reflect/scala/reflect/internal/Symbols.scala
index 858d6cf618..a7abe08c2e 100644
--- a/src/reflect/scala/reflect/internal/Symbols.scala
+++ b/src/reflect/scala/reflect/internal/Symbols.scala
@@ -127,7 +127,7 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
     def setter: Symbol = setter(owner)
   }
 
-  private[Symbols] case class SymbolKind(accurate: String, sanitized: String, abbreviation: String)
+  private[reflect] case class SymbolKind(accurate: String, sanitized: String, abbreviation: String)
 
   /** The class for all symbols */
   abstract class Symbol protected[Symbols] (initOwner: Symbol, initPos: Position, initName: Name)
diff --git a/src/reflect/scala/reflect/runtime/JavaUniverse.scala b/src/reflect/scala/reflect/runtime/JavaUniverse.scala
index 8f1c1967e0..ca2b860d08 100644
--- a/src/reflect/scala/reflect/runtime/JavaUniverse.scala
+++ b/src/reflect/scala/reflect/runtime/JavaUniverse.scala
@@ -8,7 +8,7 @@ package runtime
  *
  *  @contentDiagram hideNodes "*Api" "*Extractor"
  */
-class JavaUniverse extends internal.SymbolTable with ReflectSetup with runtime.SymbolTable { self =>
+class JavaUniverse extends internal.SymbolTable with JavaUniverseForce with ReflectSetup with runtime.SymbolTable { self =>
 
   override def inform(msg: String): Unit = log(msg)
   def picklerPhase = internal.SomePhase
@@ -87,5 +87,13 @@ class JavaUniverse extends internal.SymbolTable with ReflectSetup with runtime.S
   // Therefore, before initializing ScalaPackageClass, we must pre-initialize ObjectClass
   def init() {
     definitions.init()
+
+    // workaround for http://groups.google.com/group/scala-internals/browse_thread/thread/97840ba4fd37b52e
+    // constructors are by definition single-threaded, so we initialize all lazy vals (and local object) in advance
+    // in order to avoid deadlocks later (e.g. one thread holds a global reflection lock and waits for definitions.Something to initialize,
+    // whereas another thread holds a definitions.Something initialization lock and needs a global reflection lock to complete the initialization)
+
+    // TODO Convert this into a macro
+    force()
   }
 }
diff --git a/src/reflect/scala/reflect/runtime/JavaUniverseForce.scala b/src/reflect/scala/reflect/runtime/JavaUniverseForce.scala
new file mode 100644
index 0000000000..856a9ad8f9
--- /dev/null
+++ b/src/reflect/scala/reflect/runtime/JavaUniverseForce.scala
@@ -0,0 +1,483 @@
+// Generated Code, validated by run/t6240-universe-code-gen.scala
+package scala.reflect
+package runtime
+
+trait JavaUniverseForce { self: runtime.JavaUniverse  =>
+  def force() {
+    Literal(Constant(42)).duplicate
+    nme.flattenedName()
+    nme.raw
+    WeakTypeTag
+    TypeTag
+    TypeTag.Byte.tpe
+    TypeTag.Short.tpe
+    TypeTag.Char.tpe
+    TypeTag.Int.tpe
+    TypeTag.Long.tpe
+    TypeTag.Float.tpe
+    TypeTag.Double.tpe
+    TypeTag.Boolean.tpe
+    TypeTag.Unit.tpe
+    TypeTag.Any.tpe
+    TypeTag.AnyVal.tpe
+    TypeTag.AnyRef.tpe
+    TypeTag.Object.tpe
+    TypeTag.Nothing.tpe
+    TypeTag.Null.tpe
+
+    this.settings
+    this.treeInfo
+    // inaccessible: this.uniqueLock
+    // inaccessible: this.subsametypeLock
+    // inaccessible: this.lubglbLock
+    // inaccessible: this.indentLock
+    // inaccessible: this.toStringLock
+    // inaccessible: this.mirrors
+    this.rootMirror
+    this.treeBuild
+    // inaccessible: this.SimpleNameOrdering
+    this.traceSymbols
+    this.perRunCaches
+    this.FixedMirrorTreeCreator
+    this.FixedMirrorTypeCreator
+    this.BackquotedIdentifierAttachment
+    this.CompoundTypeTreeOriginalAttachment
+    this.noPrint
+    this.typeDebug
+    // inaccessible: this.maxFree
+    this.Range
+    // inaccessible: this.posAssigner
+    this.ConsoleWriter
+    this.RefTree
+    this.PackageDef
+    this.ClassDef
+    this.ModuleDef
+    this.ValOrDefDef
+    this.ValDef
+    this.DefDef
+    this.TypeDef
+    this.LabelDef
+    this.ImportSelector
+    this.Import
+    this.Template
+    this.Block
+    this.CaseDef
+    this.Alternative
+    this.Star
+    this.Bind
+    this.UnApply
+    this.ArrayValue
+    this.Function
+    this.Assign
+    this.AssignOrNamedArg
+    this.If
+    this.Match
+    this.Return
+    this.Try
+    this.Throw
+    this.New
+    this.Typed
+    this.TypeApply
+    this.Apply
+    this.ApplyDynamic
+    this.Super
+    this.This
+    this.Select
+    this.Ident
+    this.ReferenceToBoxed
+    this.Literal
+    this.Annotated
+    this.SingletonTypeTree
+    this.SelectFromTypeTree
+    this.CompoundTypeTree
+    this.AppliedTypeTree
+    this.TypeBoundsTree
+    this.ExistentialTypeTree
+    this.TypeTree
+    this.Modifiers
+    this.EmptyTree
+    this.noSelfType
+    this.pendingSuperCall
+    this.emptyValDef
+    this.EmptyTreeTypeSubstituter
+    // inaccessible: this.duplicator
+    this.UnmappableAnnotArg
+    this.LiteralAnnotArg
+    this.ArrayAnnotArg
+    this.NestedAnnotArg
+    this.ScalaSigBytes
+    this.AnnotationInfo
+    this.Annotation
+    this.UnmappableAnnotation
+    this.ErroneousAnnotation
+    this.ThrownException
+    // inaccessible: this.compactify
+    this.tpnme
+    this.fulltpnme
+    this.binarynme
+    this.nme
+    this.sn
+    this.Constant
+    this.definitions
+    this.LookupSucceeded
+    this.LookupAmbiguous
+    this.LookupInaccessible
+    this.LookupNotFound
+    this.Scope
+    this.EmptyScope
+    this.Flag
+    this.KindErrors
+    this.Kind
+    this.ProperTypeKind
+    this.TypeConKind
+    this.inferKind
+    // inaccessible: this.substTypeMapCache
+    this.UnmappableTree
+    this.ErrorType
+    this.WildcardType
+    this.BoundedWildcardType
+    this.NoType
+    this.NoPrefix
+    this.ThisType
+    this.SingleType
+    this.SuperType
+    this.TypeBounds
+    this.CompoundType
+    this.baseClassesCycleMonitor
+    this.RefinedType
+    this.ClassInfoType
+    this.ConstantType
+    this.TypeRef
+    this.MethodType
+    this.NullaryMethodType
+    this.PolyType
+    this.ExistentialType
+    this.OverloadedType
+    this.AntiPolyType
+    this.HasTypeMember
+    this.ArrayTypeRef
+    this.TypeVar
+    this.AnnotatedType
+    this.StaticallyAnnotatedType
+    this.NamedType
+    this.RepeatedType
+    this.ErasedValueType
+    this.GenPolyType
+    this.unwrapToClass
+    this.unwrapToStableClass
+    this.unwrapWrapperTypes
+    this.RecoverableCyclicReference
+    this.undoLog
+    // inaccessible: this.numericLoBound
+    // inaccessible: this.numericHiBound
+    this.TypeConstraint
+    this.normalizeAliases
+    this.dropSingletonType
+    this.abstractTypesToBounds
+    this.dropIllegalStarTypes
+    this.IsDependentCollector
+    this.ApproximateDependentMap
+    this.wildcardToTypeVarMap
+    this.typeVarToOriginMap
+    this.ErroneousCollector
+    this.adaptToNewRunMap
+    // inaccessible: this.commonOwnerMapObj
+    this.SymbolKind
+    this.NoSymbol
+    this.CyclicReference
+    // inaccessible: this.TypeHistory
+    this.TermName
+    this.TypeName
+    this.BooleanFlag
+    this.WeakTypeTag
+    this.TypeTag
+    this.Expr
+    this.NoMods
+    definitions.JavaLangPackage
+    definitions.JavaLangPackageClass
+    definitions.ScalaPackage
+    definitions.ScalaPackageClass
+    definitions.RuntimePackage
+    definitions.RuntimePackageClass
+    definitions.AnyClass
+    definitions.AnyRefClass
+    definitions.ObjectClass
+    definitions.AnyRefTpe
+    definitions.AnyTpe
+    definitions.AnyValTpe
+    definitions.BoxedUnitTpe
+    definitions.NothingTpe
+    definitions.NullTpe
+    definitions.ObjectTpe
+    definitions.SerializableTpe
+    definitions.StringTpe
+    definitions.ThrowableTpe
+    definitions.ConstantTrue
+    definitions.ConstantFalse
+    definitions.ConstantNull
+    definitions.AnyValClass
+    definitions.RuntimeNothingClass
+    definitions.RuntimeNullClass
+    definitions.NothingClass
+    definitions.NullClass
+    definitions.ClassCastExceptionClass
+    definitions.IndexOutOfBoundsExceptionClass
+    definitions.InvocationTargetExceptionClass
+    definitions.MatchErrorClass
+    definitions.NonLocalReturnControlClass
+    definitions.NullPointerExceptionClass
+    definitions.ThrowableClass
+    definitions.UninitializedErrorClass
+    definitions.UninitializedFieldConstructor
+    definitions.PartialFunctionClass
+    definitions.AbstractPartialFunctionClass
+    definitions.SymbolClass
+    definitions.StringClass
+    definitions.StringModule
+    definitions.ClassClass
+    definitions.DynamicClass
+    definitions.SysPackage
+    definitions.UnqualifiedModules
+    definitions.UnqualifiedOwners
+    definitions.PredefModule
+    definitions.SpecializableModule
+    definitions.GroupOfSpecializable
+    definitions.ScalaRunTimeModule
+    definitions.SymbolModule
+    definitions.Symbol_apply
+    definitions.StringAddClass
+    definitions.ArrowAssocClass
+    definitions.StringAdd_$plus
+    definitions.ScalaNumberClass
+    definitions.TraitSetterAnnotationClass
+    definitions.DelayedInitClass
+    definitions.TypeConstraintClass
+    definitions.SingletonClass
+    definitions.SerializableClass
+    definitions.JavaSerializableClass
+    definitions.ComparableClass
+    definitions.JavaCloneableClass
+    definitions.JavaNumberClass
+    definitions.RemoteInterfaceClass
+    definitions.RemoteExceptionClass
+    definitions.ByNameParamClass
+    definitions.JavaRepeatedParamClass
+    definitions.RepeatedParamClass
+    definitions.ExprClassOf
+    definitions.ConsClass
+    definitions.IteratorClass
+    definitions.IterableClass
+    definitions.ListClass
+    definitions.SeqClass
+    definitions.StringBuilderClass
+    definitions.TraversableClass
+    definitions.ListModule
+    definitions.List_apply
+    definitions.NilModule
+    definitions.SeqModule
+    definitions.ArrayModule
+    definitions.ArrayModule_overloadedApply
+    definitions.ArrayClass
+    definitions.Array_apply
+    definitions.Array_update
+    definitions.Array_length
+    definitions.Array_clone
+    definitions.SoftReferenceClass
+    definitions.MethodClass
+    definitions.EmptyMethodCacheClass
+    definitions.MethodCacheClass
+    definitions.ScalaXmlTopScope
+    definitions.ScalaXmlPackage
+    definitions.ReflectPackage
+    definitions.ReflectApiPackage
+    definitions.ReflectRuntimePackage
+    definitions.PartialManifestClass
+    definitions.PartialManifestModule
+    definitions.FullManifestClass
+    definitions.FullManifestModule
+    definitions.OptManifestClass
+    definitions.NoManifest
+    definitions.TreesClass
+    definitions.TreesTreeType
+    definitions.TreeType
+    definitions.SubtreeType
+    definitions.ExprsClass
+    definitions.ExprClass
+    definitions.ClassTagModule
+    definitions.ClassTagClass
+    definitions.TypeTagsClass
+    definitions.WeakTypeTagClass
+    definitions.WeakTypeTagModule
+    definitions.TypeTagClass
+    definitions.TypeTagModule
+    definitions.ApiUniverseClass
+    definitions.JavaUniverseClass
+    definitions.MirrorClass
+    definitions.TypeCreatorClass
+    definitions.TreeCreatorClass
+    definitions.LiftableClass
+    definitions.MacroClass
+    definitions.MacroContextClass
+    definitions.MacroImplAnnotation
+    definitions.StringContextClass
+    definitions.QuasiquoteClass
+    definitions.QuasiquoteClass_api
+    definitions.QuasiquoteClass_api_apply
+    definitions.QuasiquoteClass_api_unapply
+    definitions.ScalaSignatureAnnotation
+    definitions.ScalaLongSignatureAnnotation
+    definitions.OptionClass
+    definitions.OptionModule
+    definitions.Option_apply
+    definitions.SomeClass
+    definitions.NoneModule
+    definitions.SomeModule
+    definitions.VarArityClass
+    definitions.ProductClass
+    definitions.TupleClass
+    definitions.FunctionClass
+    definitions.AbstractFunctionClass
+    definitions.ProductRootClass
+    definitions.Any_$eq$eq
+    definitions.Any_$bang$eq
+    definitions.Any_equals
+    definitions.Any_hashCode
+    definitions.Any_toString
+    definitions.Any_$hash$hash
+    definitions.Any_getClass
+    definitions.Any_isInstanceOf
+    definitions.Any_asInstanceOf
+    definitions.primitiveGetClassMethods
+    definitions.getClassMethods
+    definitions.Object_$hash$hash
+    definitions.Object_$eq$eq
+    definitions.Object_$bang$eq
+    definitions.Object_eq
+    definitions.Object_ne
+    definitions.Object_isInstanceOf
+    definitions.Object_asInstanceOf
+    definitions.Object_synchronized
+    definitions.String_$plus
+    definitions.ObjectRefClass
+    definitions.VolatileObjectRefClass
+    definitions.RuntimeStaticsModule
+    definitions.BoxesRunTimeModule
+    definitions.BoxesRunTimeClass
+    definitions.BoxedNumberClass
+    definitions.BoxedCharacterClass
+    definitions.BoxedBooleanClass
+    definitions.BoxedByteClass
+    definitions.BoxedShortClass
+    definitions.BoxedIntClass
+    definitions.BoxedLongClass
+    definitions.BoxedFloatClass
+    definitions.BoxedDoubleClass
+    definitions.Boxes_isNumberOrBool
+    definitions.Boxes_isNumber
+    definitions.BoxedUnitClass
+    definitions.BoxedUnitModule
+    definitions.AnnotationClass
+    definitions.ClassfileAnnotationClass
+    definitions.StaticAnnotationClass
+    definitions.BridgeClass
+    definitions.ElidableMethodClass
+    definitions.ImplicitNotFoundClass
+    definitions.MigrationAnnotationClass
+    definitions.ScalaStrictFPAttr
+    definitions.SwitchClass
+    definitions.TailrecClass
+    definitions.VarargsClass
+    definitions.uncheckedStableClass
+    definitions.uncheckedVarianceClass
+    definitions.BeanPropertyAttr
+    definitions.BooleanBeanPropertyAttr
+    definitions.CompileTimeOnlyAttr
+    definitions.DeprecatedAttr
+    definitions.DeprecatedNameAttr
+    definitions.DeprecatedInheritanceAttr
+    definitions.DeprecatedOverridingAttr
+    definitions.NativeAttr
+    definitions.RemoteAttr
+    definitions.ScalaInlineClass
+    definitions.ScalaNoInlineClass
+    definitions.SerialVersionUIDAttr
+    definitions.SerialVersionUIDAnnotation
+    definitions.SpecializedClass
+    definitions.ThrowsClass
+    definitions.TransientAttr
+    definitions.UncheckedClass
+    definitions.UncheckedBoundsClass
+    definitions.UnspecializedClass
+    definitions.VolatileAttr
+    definitions.BeanGetterTargetClass
+    definitions.BeanSetterTargetClass
+    definitions.FieldTargetClass
+    definitions.GetterTargetClass
+    definitions.ParamTargetClass
+    definitions.SetterTargetClass
+    definitions.ObjectTargetClass
+    definitions.ClassTargetClass
+    definitions.MethodTargetClass
+    definitions.LanguageFeatureAnnot
+    definitions.languageFeatureModule
+    definitions.experimentalModule
+    definitions.MacrosFeature
+    definitions.DynamicsFeature
+    definitions.PostfixOpsFeature
+    definitions.ReflectiveCallsFeature
+    definitions.ImplicitConversionsFeature
+    definitions.HigherKindsFeature
+    definitions.ExistentialsFeature
+    definitions.metaAnnotations
+    definitions.AnnotationDefaultAttr
+    definitions.isUnbox
+    definitions.isBox
+    definitions.isPhantomClass
+    definitions.syntheticCoreClasses
+    definitions.syntheticCoreMethods
+    definitions.hijackedCoreClasses
+    definitions.symbolsNotPresentInBytecode
+    definitions.isPossibleSyntheticParent
+    // inaccessible: definitions.boxedValueClassesSet
+    definitions.abbrvTag
+    definitions.numericWeight
+    definitions.boxedModule
+    definitions.boxedClass
+    definitions.refClass
+    definitions.volatileRefClass
+    definitions.boxMethod
+    definitions.unboxMethod
+    definitions.UnitClass
+    definitions.ByteClass
+    definitions.ShortClass
+    definitions.CharClass
+    definitions.IntClass
+    definitions.LongClass
+    definitions.FloatClass
+    definitions.DoubleClass
+    definitions.BooleanClass
+    definitions.Boolean_and
+    definitions.Boolean_or
+    definitions.Boolean_not
+    definitions.UnitTpe
+    definitions.ByteTpe
+    definitions.ShortTpe
+    definitions.CharTpe
+    definitions.IntTpe
+    definitions.LongTpe
+    definitions.FloatTpe
+    definitions.DoubleTpe
+    definitions.BooleanTpe
+    definitions.ScalaNumericValueClasses
+    definitions.ScalaValueClassesNoUnit
+    definitions.ScalaValueClasses
+
+
+    erasure.GenericArray
+    erasure.scalaErasure
+    erasure.specialScalaErasure
+    erasure.javaErasure
+    erasure.verifiedJavaErasure
+    erasure.boxingErasure
+  }
+}
\ No newline at end of file