Refining the reflection api.

In the pursuit of simplicity and consistency.

- Method names like getType, getClass, and getValue are far too ambiguous,
  both internally and especially with java reflection names.  Methods which
  accept or return scala symbols should not refer to them as "classes" in
  the reflection library.  (We can live with the FooClass convention for naming
  the well-known symbols, it's names like "getClass" and "classToType" which
  are needlessly conflationary.)
- Meaningless names like "subst" have to be expanded.
- We should hew closely to the terms which are used by scala programmers
  wherever possible, thus using "thisType" to mean "C.this" can only beget confusion,
  given that "thisType" doesn't mean "this.type" but what is normally called
  the "self type."
- It's either "enclosing" or "encl", not both, and similar consistency issues.
- Eliminated getAnnotations.
- Removed what I could get away with from the API; would like to push
  those which are presently justified as being "required for LiftCode" out of the core.
- Changed a number of AnyRefs to Any both on general principles and because
  before long it may actually matter.
- There are !!!s scattered all over this commit, mostly where I think
  the name could be better.
- I think we should standardize on method names like "vmSignature, vmClass" etc.
  when we are talking about jvm (and ostensibly other vm) things.
  There are a bunch more places to make this distinction clear (e.g.
  Symbol's javaBinaryName, etc.)
- There is a lot more I want to do on this and I don't know where the
  time will come from to do it.

Review by @odersky, @scalamacros.

1 files changed, 0 insertions, 26 deletions

diff --git a/src/scalap/scala/tools/scalap/Classfiles.scala b/src/scalap/scala/tools/scalap/Classfiles.scala
index 72b3824157..2cbeaa945f 100644
--- a/src/scalap/scala/tools/scalap/Classfiles.scala
+++ b/src/scalap/scala/tools/scalap/Classfiles.scala
@@ -41,31 +41,5 @@ object Classfiles {
     CONSTANT_INTFMETHODREF -> "InterfaceMethod",
     CONSTANT_NAMEANDTYPE -> "NameAndType"
   )
-
-  final val BAD_ATTR = 0x00000
-  final val SOURCEFILE_ATTR = 0x00001
-  final val SYNTHETIC_ATTR = 0x00002
-  final val DEPRECATED_ATTR = 0x00004
-  final val CODE_ATTR = 0x00008
-  final val EXCEPTIONS_ATTR = 0x00010
-  final val CONSTANT_VALUE_ATTR = 0x00020
-  final val LINE_NUM_TABLE_ATTR = 0x00040
-  final val LOCAL_VAR_TABLE_ATTR = 0x00080
-  final val INNERCLASSES_ATTR = 0x08000
-  final val META_ATTR = 0x10000
-  final val SCALA_ATTR = 0x20000
-
-  final val SOURCEFILE_N = "SourceFile"
-  final val SYNTHETIC_N = "Synthetic"
-  final val DEPRECATED_N = "Deprecated"
-  final val CODE_N = "Code"
-  final val EXCEPTIONS_N = "Exceptions"
-  final val CONSTANT_VALUE_N = "ConstantValue"
-  final val LINE_NUM_TABLE_N = "LineNumberTable"
-  final val LOCAL_VAR_TABLE_N = "LocalVariableTable"
-  final val INNERCLASSES_N = "InnerClasses"
-  final val META_N = "JacoMeta"
-  final val SCALA_N = "ScalaSignature"
-  final val CONSTR_N = "<init>"
 }