summaryrefslogtreecommitdiff
path: root/test/files/neg/abstract-inaccessible.scala
diff options
context:
space:
mode:
authorPaul Phillips <paulp@improving.org>2011-06-29 16:59:10 +0000
committerPaul Phillips <paulp@improving.org>2011-06-29 16:59:10 +0000
commitfdfdd09d51f5ad3ee30e525145001f02959e3899 (patch)
treed82571210dc11a000cc15d6b17bda35b58bdee78 /test/files/neg/abstract-inaccessible.scala
parent72a095dcdc84a988c61835d8115fd2738caa5127 (diff)
downloadscala-fdfdd09d51f5ad3ee30e525145001f02959e3899.tar.gz
scala-fdfdd09d51f5ad3ee30e525145001f02959e3899.tar.bz2
scala-fdfdd09d51f5ad3ee30e525145001f02959e3899.zip
Warning! Warning! Yes, that's what's in this co...
Warning! Warning! Yes, that's what's in this commit. Why are you panicking? Mostly new command line options: -Xlint // basically, the ones which aren't noisy Ywarn-all -Ywarn-dead-code Ywarn-inaccessible // try this one on the library: -it makes some good points Ywarn-nullary-override Ywarn-nullary-unit -Ywarn-numeric-widen Ywarn-value-discard Some accumulated motivations: The wontfix resolution of ticket #4506 indicates that "def foo" and "def foo()" are always going to be treated differently in some situations and the same in others without users having any way to fix it. Summary expressed in latest comment with which I agree (and quite sadly, given that I've done a lot of work to try to make them usable) is "avoid using structural types like the plague." But the least we can do is warn if you're using parentheses "wrong". I think it would be better if the warning about "def foo()" overriding "def foo" were an error instead. If we have to live with this... trait Me { def f(): Int } class A { def f: Int = 5 } class C extends A with Me { } // error: Int does not take parameters def f(x: C) = x.f() // compiles def f(x: Me) = x.f() // error: Int does not take parameters. Mmph, how can a method be // legal with parameter "Foo" and illegal with parameter "Foo with // Bar" ? def f(x: Me with C) = x.f() The warning about a method contains a reference to a type which is less accessible than the method itself is obviously to those who recall it a response to GenTraversable being private and appearing in flatMap's signature during the 2.9.0 RCs. It avoids warning in the case where the unnormalized type is inaccessible but the normalized version would be, but it could use further refinement.
Diffstat (limited to 'test/files/neg/abstract-inaccessible.scala')
-rw-r--r--test/files/neg/abstract-inaccessible.scala9
1 files changed, 9 insertions, 0 deletions
diff --git a/test/files/neg/abstract-inaccessible.scala b/test/files/neg/abstract-inaccessible.scala
new file mode 100644
index 0000000000..3c80f30522
--- /dev/null
+++ b/test/files/neg/abstract-inaccessible.scala
@@ -0,0 +1,9 @@
+package foo {
+ private[foo] trait Bippy { }
+
+ trait YourTrait {
+ def implementMe(f: Int => (String, Bippy)): Unit
+ def overrideMe[T <: Bippy](x: T): T = x
+ def overrideMeAlso(x: Map[Int, Set[Bippy]]) = 5
+ }
+}