diff options
| author | Paul Phillips <paulp@improving.org> | 2010-10-03 22:53:59 +0000 |
|---|---|---|
| committer | Paul Phillips <paulp@improving.org> | 2010-10-03 22:53:59 +0000 |
| commit | a03131199109b51b4a3051aa2c016d516bec6e36 (patch) | |
| tree | d4f6eb62ea09145f8a005ea85a54eb9bd3fc332d /test/files/neg/patmatexhaust.check | |
| parent | 2c59afc2c15ddcd124fd175eb30c0cdf9d98463b (diff) | |
| download | scala-a03131199109b51b4a3051aa2c016d516bec6e36.tar.gz scala-a03131199109b51b4a3051aa2c016d516bec6e36.tar.bz2 scala-a03131199109b51b4a3051aa2c016d516bec6e36.zip | |
Work on the pattern matcher.
patches for #3887 and #3888, but I determined that I could achieve the
same effect by deleting a bunch of code, so I did. This left only a few
lines in TransMatch, so I eliminated it, which led me to remember that
many places still reference non-existent phase transmatch, so those were
updated. Notes:
* This swaps equality tests on stable identifier patterns. They
have never conformed to the spec (as noted long ago in ticket #785)
which says "The pattern matches any value v such that r == v" whereas
until now the test being performed was v == r.
* An issue was introduced with specialization in that the implementation
of "isTupleType" in Definitions relied upon sym == TupleClass(elems.length).
This test is untrue for specialized tuples, causing mysterious behavior
because only some tuples are specialized. There is now "isTupleTypeOrSubtype"
although it seems likely the former implementation is unnecessary.
The issue is sidestepped if one uses "getProductArgs" to retrieve the element
types because it sifts through the base types for the Product symbol.
Closes #3887 and #3888, review by dmharrah.
Diffstat (limited to 'test/files/neg/patmatexhaust.check')
| -rw-r--r-- | test/files/neg/patmatexhaust.check | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/files/neg/patmatexhaust.check b/test/files/neg/patmatexhaust.check index ca769300c0..83c4279b0a 100644 --- a/test/files/neg/patmatexhaust.check +++ b/test/files/neg/patmatexhaust.check @@ -13,7 +13,7 @@ missing combination Kult Kult missing combination Qult Qult def ma3(x:Mult) = (x,x) match { // not exhaustive - ^ + ^ patmatexhaust.scala:49: warning: match is not exhaustive! missing combination Gp missing combination Gu |