diff options
| author | Mads Hartmann Jensen <mads379@gmail.com> | 2013-01-26 20:01:36 +0100 |
|---|---|---|
| committer | Mads Hartmann Jensen <mads379@gmail.com> | 2013-02-07 10:47:29 +0100 |
| commit | 79e774f584d5afed72f62b0a7f93f63765d0cb99 (patch) | |
| tree | d99abfc9d29b1872d8dcab325257aa61c05d889b /test/files/presentation/ide-t1001326.check | |
| parent | 5d65772762072aa950a488c666673dc248b01d6d (diff) | |
| download | scala-79e774f584d5afed72f62b0a7f93f63765d0cb99.tar.gz scala-79e774f584d5afed72f62b0a7f93f63765d0cb99.tar.bz2 scala-79e774f584d5afed72f62b0a7f93f63765d0cb99.zip | |
SI-7026: parseTree should never return a typed one
This commit fixes ticket SI-7026. This makes it safe to use
parseTree outside of the presentation compiler thread.
Solved it with an implementation that just parses the source every
time without trying to memorize anything. Added tests that checks
that
1. You get a new parse tree every time you ask for one.
2. You always get a parse tree, never a typed tree.
3. A parse tree should never contain any symbols or types [1].
4. If you ask for a parse tree and then ask for a typed tree it
shouldn't change the parse tree you originally asked for, i.e.
property 3 still holds.
Additionally the parser is now only interruptible when running
on the presentation compiler thread.
[1] There is an exception to this though. Some of the nodes that
the compiler generates will actually contain symbols. I've
chosen to just ignore these special cases for now.
Diffstat (limited to 'test/files/presentation/ide-t1001326.check')
| -rw-r--r-- | test/files/presentation/ide-t1001326.check | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/files/presentation/ide-t1001326.check b/test/files/presentation/ide-t1001326.check new file mode 100644 index 0000000000..0ac15faed4 --- /dev/null +++ b/test/files/presentation/ide-t1001326.check @@ -0,0 +1,4 @@ +Unique OK +Unattributed OK +NeverModify OK +AlwaysParseTree OK
\ No newline at end of file |