Leveraged -Xmigration to burn off some warts wh...

Leveraged -Xmigration to burn off some warts which arose in the new
collections. Warnings put in place for behavioral changes, allowing the
following. 1) Buffers: create new collections on

++ and -- like all the other collections.  2) Maps: eliminated
never-shipped redundant method valuesIterable and supplied these
return types:

  def keys: Iterable[A]
  def keysIterator: Iterator[A]
  def values: Iterable[B]
  def valuesIterator: Iterator[B]
  def keySet: Set[A]

I concluded that keys should return Iterable because keySet also exists
on Map, and is not solely in the province of Maps even if we wanted to
change it: it's defined on Sorted and also appears in some Sets. So it
seems sensible to have keySet return a Set and keys return the more
general type.

Closes #3089, #3145.  Review by odersky.

1 files changed, 1 insertions, 2 deletions

diff --git a/test/files/run/t2526.scala b/test/files/run/t2526.scala
index 5f6d60546a..235aca234d 100644
--- a/test/files/run/t2526.scala
+++ b/test/files/run/t2526.scala
@@ -20,9 +20,8 @@ object Test {
     assertForeach(keys, m.keysIterator)
     assertForeach(keys, m.keySet)
 
-    assertForeach(values, m.valuesIterable.iterator)
+    assertForeach(values, m.values.iterator)
     assertForeach(values, m.valuesIterator)
-    assertForeach(values, m.valuesIterable)
 
     assertForeach(entries, m)
   }