Fixes SI-4929, with a test to verify.

Also fixes potential issue with Parsers.phrase not being reentrant; however, I was unable to actually reproduce this issue in practice. (The order in which lastNoSuccess was being set and compared seemed to guarantee that it would never actually be a problem).

1 files changed, 42 insertions, 0 deletions

diff --git a/test/files/run/t4929.scala b/test/files/run/t4929.scala
new file mode 100644
index 0000000000..3208cd1b09
--- /dev/null
+++ b/test/files/run/t4929.scala
@@ -0,0 +1,42 @@
+import scala.util.parsing.json._
+import java.util.concurrent._
+import collection.JavaConversions._
+
+object Test extends App {
+
+  val LIMIT = 2000
+  val THREAD_COUNT = 20
+  val count = new java.util.concurrent.atomic.AtomicInteger(0)
+
+  val begin = new CountDownLatch(THREAD_COUNT)
+  val finish = new CountDownLatch(THREAD_COUNT)
+
+  val errors = new ConcurrentLinkedQueue[Throwable]
+
+  (1 to THREAD_COUNT) foreach { i =>
+    val thread = new Thread {
+      override def run() {
+        begin.await(1, TimeUnit.SECONDS)
+        try {
+          while (count.getAndIncrement() < LIMIT && errors.isEmpty) {
+            JSON.parseFull("""{"foo": [1,2,3,4]}""")
+          }
+        } catch {
+          case t: Throwable => errors.add(t)
+        }
+
+        finish.await(10, TimeUnit.SECONDS)
+      }
+    }
+
+    thread.setDaemon(true)
+    thread.start()
+
+  }
+
+
+  errors foreach { throw(_) }
+
+  println("success")
+
+}