SI-9546 Fix regression in rewrite of case apply to constructor call

In SI-9425, I disabled the rewrite of `CaseClass.apply(x)` to
`new CaseClass(x)` if the constructor was was less accessible
than the apply method. This solved a problem with spurious
"constructor cannot be accessed" errors during refchecks for
case classes with non-public constructors.

However, for polymorphic case classes, refchecks was persistent,
and even after refusing to transform the `TypeApply` within:

    CaseClass.apply[String]("")

It *would* try again to transform the enclosing `Select`, a
code path only intended for monomorphic case classes. The tree has
a `PolyType`, which foiled the newly added accessibility check.

I've modified the call to `isSimpleCaseApply` from the transform
of `Select` nodes to exclude polymorphic apply's from being
considered twice.

0 files changed, 0 insertions, 0 deletions