summaryrefslogtreecommitdiff
path: root/test/files
diff options
context:
space:
mode:
authorJason Zaugg <jzaugg@gmail.com>2013-06-16 14:15:30 -0400
committerJason Zaugg <jzaugg@gmail.com>2013-06-16 17:09:33 -0400
commit83ae74ce9d3ff56c47b39e44332daa3da2981133 (patch)
tree2dfcbdad1ecb2039fe606730f348c2bdb2267d19 /test/files
parent70a93f52c3efafe604d6547b335cc361deff4f29 (diff)
downloadscala-83ae74ce9d3ff56c47b39e44332daa3da2981133.tar.gz
scala-83ae74ce9d3ff56c47b39e44332daa3da2981133.tar.bz2
scala-83ae74ce9d3ff56c47b39e44332daa3da2981133.zip
SI-7584 Fix typer regression with by-name parameter types
It regressed in fada1ef6b#L4L614. Partially reverting just this change restores the correct behaviour: ``` - if (sym.isStable && pre.isStable && !isByNameParamType(tree.tpe) && + if (treeInfo.admitsTypeSelection(tree) && ``` This patch embeds the check for by-name parameter types into `TreeInfo.isStableIdentifier`. That code already checks for `Symbol#isStable`, which exludes direct references to by-name parameters. But the additional check is required to deal with by-name parameters in function types, e.g `(=> Int) => Any`. Open question: should we go further and embed this check in `isStable`? Currently: final def isStable = isTerm && !isMutable && !(hasFlag(BYNAMEPARAM)) && (!isMethod || hasStableFlag) Such function types are an underspecified corner of the language, albeit one that is pretty useful writing, for example, in the signature of a lazy foldRight that can operate over infinite structures: def foldRight[A, B](fa: F[A], z: => B)(f: (A, => B) => B): B The next commit subjects them to a little testing.
Diffstat (limited to 'test/files')
-rw-r--r--test/files/pos/t7584.scala11
1 files changed, 11 insertions, 0 deletions
diff --git a/test/files/pos/t7584.scala b/test/files/pos/t7584.scala
new file mode 100644
index 0000000000..52d127ecb9
--- /dev/null
+++ b/test/files/pos/t7584.scala
@@ -0,0 +1,11 @@
+object Test {
+ def fold[A, B](f: (A, => B) => B) = ???
+ def f[A, B](x: A, y: B): B = ???
+ def bip[A, B] = fold[A, B]((x, y) => f(x, y))
+ def bop[A, B] = fold[A, B](f)
+
+ // these work:
+ fold[Int, Int]((x, y) => f(x, y))
+ fold[Int, Int](f)
+}
+