diff options
| author | Eugene Burmako <xeno.by@gmail.com> | 2013-11-22 22:13:44 +0100 |
|---|---|---|
| committer | Eugene Burmako <xeno.by@gmail.com> | 2013-11-23 14:39:11 +0100 |
| commit | 66577fa6ec07de9769150019deeafb25a1e5422a (patch) | |
| tree | fe6228f2a528c47c7e08d35ff3caa201410a00f3 /test | |
| parent | 42657a6918ef7d6fd3f36838739ec8a3b64744a3 (diff) | |
| download | scala-66577fa6ec07de9769150019deeafb25a1e5422a.tar.gz scala-66577fa6ec07de9769150019deeafb25a1e5422a.tar.bz2 scala-66577fa6ec07de9769150019deeafb25a1e5422a.zip | |
SI-8001 spurious "pure expression does nothing" warning
`isPureExprForWarningPurposes` doesn’t warn on `()`, but `(): Unit`
leaves it confused. This patch fixes the problem.
The fix is important in the context of the recent split between blackbox
and whitebox macros. Macro engines wrap expansions of blackbox macros
in type ascriptions, so a macro that expands into `()` would actually
produce `(): Unit`, which would trigger a spurious warning. Thanks
@milessabin for spotting this problem!
Diffstat (limited to 'test')
| -rw-r--r-- | test/files/pos/t8001.check | 0 | ||||
| -rw-r--r-- | test/files/pos/t8001.flags | 1 | ||||
| -rw-r--r-- | test/files/pos/t8001/Macros_1.scala | 10 | ||||
| -rw-r--r-- | test/files/pos/t8001/Test_2.scala | 4 | ||||
| -rw-r--r-- | test/files/run/macro-system-properties.check | 6 |
5 files changed, 15 insertions, 6 deletions
diff --git a/test/files/pos/t8001.check b/test/files/pos/t8001.check new file mode 100644 index 0000000000..e69de29bb2 --- /dev/null +++ b/test/files/pos/t8001.check diff --git a/test/files/pos/t8001.flags b/test/files/pos/t8001.flags new file mode 100644 index 0000000000..e8fb65d50c --- /dev/null +++ b/test/files/pos/t8001.flags @@ -0,0 +1 @@ +-Xfatal-warnings
\ No newline at end of file diff --git a/test/files/pos/t8001/Macros_1.scala b/test/files/pos/t8001/Macros_1.scala new file mode 100644 index 0000000000..1f8dab51c1 --- /dev/null +++ b/test/files/pos/t8001/Macros_1.scala @@ -0,0 +1,10 @@ +import scala.language.experimental.macros +import scala.reflect.macros.BlackboxContext + +object Macros { + def foo = macro impl + def impl(c: BlackboxContext) = { + import c.universe._ + q"()" + } +}
\ No newline at end of file diff --git a/test/files/pos/t8001/Test_2.scala b/test/files/pos/t8001/Test_2.scala new file mode 100644 index 0000000000..6d72d96070 --- /dev/null +++ b/test/files/pos/t8001/Test_2.scala @@ -0,0 +1,4 @@ +object Test extends App { + Macros.foo + (): Unit +}
\ No newline at end of file diff --git a/test/files/run/macro-system-properties.check b/test/files/run/macro-system-properties.check index b102d319ec..ea4c5a664a 100644 --- a/test/files/run/macro-system-properties.check +++ b/test/files/run/macro-system-properties.check @@ -14,15 +14,9 @@ scala> object GrabContext { defined object GrabContext scala> object Test { class C(implicit a: Any) { GrabContext.grab } } -<console>:12: warning: a pure expression does nothing in statement position; you may be omitting necessary parentheses - object Test { class C(implicit a: Any) { GrabContext.grab } } - ^ defined object Test scala> object Test { class C(implicit a: Any) { GrabContext.grab } } -<console>:12: warning: a pure expression does nothing in statement position; you may be omitting necessary parentheses - object Test { class C(implicit a: Any) { GrabContext.grab } } - ^ defined object Test scala> |