| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |_|/ / / /
|/| | | | | |
|
| |\ \ \ \ \ \
| | |_|_|_|/
| |/| | | | |
Statistics improvements and bug fixes.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Added compile-time option hotEnabled to Statistics that can be used to count very high frequency methods with 0 overhead for the disabled case. Fixed problem with weak maps that caused some timers to be discarded prematurely before they could be printed. Fixed problem with accouning for stacked timers.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Minor followup on SI-4842: remove awkward condition. Review by @retronym
|
| | | |/ / /
| |/| | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
SI-5966 Fix eta expansion for repeated parameters with zero arguments.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reworks part of e33901 / SI-5610, which was inserting an <empty> tree
as an argument in this case, which turns into a null in icode.
|
| |\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
SI-5968 Eliminate spurious exhaustiveness warning with singleton types.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
A singleton type is a type ripe for enumeration.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove semi-colons and extraneous whitespace
|
| | |/ / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove semi-colons and extraneous whitespace
|
| | |/ / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Adds missing closing curly brace to ScalaDoc code example.
|
| | |/ / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-5951 add `narrow` to the reflection API
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
as per https://issues.scala-lang.org/browse/SI-5951
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Added a key comment.
|
| | | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The commit message from f4d2678c42 works a lot better up close
and personal with the change.
|
| |\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
SI-4989 Reject super.x if an intermediate class declares x abstract.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is in line with Java's treatment. Without this, an AbstractMethodError
is thrown at runtime.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix SI-4809.
|
| | | |_|_|_|_|/
| |/| | | | | |
|
| |\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | | |
Fix SI-5284.
|
| | | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The problem was the false assumption that methods specialized
on their type parameter, such as this one:
class Foo[@spec(Int) T](val x: T) {
def bar[@spec(Int) S >: T](f: S => S) = f(x)
}
have their normalized versions (`bar$mIc$sp`) never called
from the base specialization class `Foo`.
This meant that the implementation of `bar$mIc$sp` in `Foo`
simply threw an exception.
This assumption is not true, however. See this:
object Baz {
def apply[T]() = new Foo[T]
}
Calling `Baz.apply[Int]()` will create an instance of the
base specialization class `Foo` at `Int`.
Calling `bar` on this instance will be rewritten by
specialization to calling `bar$mIc$sp`, hence the error.
So, we have to emit a valid implementation for `bar`,
obviously.
Problem is, such an implementation would have conflicting
type bounds in the base specialization class `Foo`, since
we don't know if `T` is a subtype of `S = Int`.
In other words, we cannot emit:
def bar$mIc$sp(f: Int => Int) = f(x) // x: T
without typechecking errors.
However, notice that the bounds are valid if and only if
`T = Int`. In the same time, invocations of `bar$mIc$sp` will only
be emitted in callsites where the type bounds hold.
This means we can cast the expressions in method applications
to the required specialized type bound.
The following changes have been made:
1) The decision of whether or not to create a normalized
version of the specialized method is not done on the
`conflicting` relation anymore.
Instead, it's done based on the `satisfiable` relation,
which is true if there is possibly an instantiation of
the type parameters where the bounds hold.
2) The `satisfiable` method has a new variant called
`satisfiableConstraints`, which does unification to
figure out how the type parameters should be instantiated
in order to satisfy the bounds.
3) The `Duplicators` are changed to transform a tree
using the `castType` method which just returns the tree
by default.
In specialization, the `castType` in `Duplicators` is overridden,
and uses a map from type parameters to types.
This map is obtained by `satisfiableConstraints` from 2).
If the type of the expression is not equal to the expected type,
and this map contains a mapping to the expected type, then
the tree is cast, as discussed above.
Additional tests added.
Review by @dragos
Review by @VladUreche
Conflicts:
src/compiler/scala/tools/nsc/transform/SpecializeTypes.scala
src/compiler/scala/tools/nsc/typechecker/Duplicators.scala
|
| |\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
SI-2807 Resurrect and refine the promiscuous catch warning.
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The previous incarnation didn't survive 4fb3473.
This version can be cleared by using a typed pattern: `catch { case _: Throwable => }`.
This is motivated by the recent appearance of such a catch in `util.Try`, and by battle
scars left by one too many processes bravely but stupidly catching and logging OutOfMemoryErrors.
-Y status has been skipped: this warning is enabled by default and can only be silenced
with use of a typed pattern.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Issue/hardening compiling with newer sources
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When a symbol needed in Definitions is loaded, it may be that the corresponding source is newer than
the classfile. That will send it to `compileLate`, but no phase is yet set. We simply add it to the
compilation pipeline and continue gracefully.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The parser special-cases primitive types. For comparing the name, it relied on having the symbols
for primitive types already loaded, which is not always the case. The presentation compiler
may parse sources for, say, scala.Int, and therefore the symbol for Int may not be yet available.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When the presentation compiler needs a SourceLoader, instead of immediately adding the file
to the compilation round it uses a fast parser to create symbols for all top-level class definitions.
The fast parser assumes Scala sources, which is not always the case.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Updated scalacheck sources.
|
| | | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
To current scalacheck head 7ffda752d8 except for this diff:
diff -rw src/scalacheck/org/scalacheck/Arbitrary.scala /s/scalacheck/src/main/scala/org/scalacheck/Arbitrary.scala
13d12
< import scala.reflect.ClassTag
281c280
< implicit def arbArray[T](implicit a: Arbitrary[T], c: ClassTag[T]
---
> implicit def arbArray[T](implicit a: Arbitrary[T], c: ClassManifest[T]
diff -rw src/scalacheck/org/scalacheck/Prop.scala /s/scalacheck/src/main/scala/org/scalacheck/Prop.scala
63c63
< def mainCallsExit = false
---
> def mainCallsExit = true
Only in /s/scalacheck/src/main/scala/org/scalacheck: ScalaCheckFramework.scala
diff -rw src/scalacheck/org/scalacheck/util/Buildable.scala /s/scalacheck/src/main/scala/org/scalacheck/util/Buildable.scala
13d12
< import scala.reflect.ClassTag
34c33
< implicit def buildableArray[T](implicit cm: ClassTag[T]) =
---
> implicit def buildableArray[T](implicit cm: ClassManifest[T]) =
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-4842 Forbid access to in-construction this in self-constructor args
|
| | | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The check was already in place for direct calls to the super constructor.
Without this additional check, ExplicitOuter crashes, as it doesn't create
an $outer pointer for the constructor-arg scoped inner object, but expects
one to exist when transforming the Outer.this reference.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-5617 Better error message for "x overrides nothing".
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
"It looks like you're trying to override a method", notes Clippy.
|
| |\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Don't crash if cpsParam is not on the classpath.
|
| | | |_|/ /
| |/| | |
| | | | | |
When checking if a piece of code needs the continuations plugin, the cpsParam classes may not be on the class path. Assume it does not need it in that case.
|
| | |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As usual, .tpe -> .tpeHK. As a side note following an old theme,
if symbols of type parameters knew that they were symbols of type
parameters, they could call tpeHK themselves rather than every call
site having to do it. It's the operation which injects dummies which
should require explicit programmer action, not the operation which
faithfully reproduces the unapplied type. Were it that way, errors could
be caught much more quickly via ill-kindedness.
Seems like an improvement over lurking compiler crashes at every call
to tparam.tpe.
|
| |\ \ \ \
| | | | |
| | | | | |
Fix SI-4541.
|
| | | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Catch type errors when duplicating trees.
In this case, to access a protected member from a specialized
class is an error, so we would have to make the member public
anyway.
Better it is then to report an error and have the user make the
field public explicitly.
Review by @dragos.
|
| |\ \ \ \
| | | | |
| | | | | |
Fix for java parser edge case.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Empty statements are A-OK. Closes SI-5910. Review by @dragos.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Statistics reorganization
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Statistics were broken since the move to reflect.internal. They are now
re-organized, made more robost and modular.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
enables reification of anonymous classes
|
| | | |_|/ / /
| |/| | | | |
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
improve showRaw
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
addresses concerns raised in http://groups.google.com/group/scala-user/browse_thread/thread/de5a5be2e083cf8e
|
