[SQL][minor] make it more clear that we only need to re-throw GetField exception for UnresolvedAttribute

For `GetField` outside `UnresolvedAttribute`, we will throw exception in `Analyzer`.

Author: Wenchen Fan <cloud0fan@outlook.com>

Closes #5588 from cloud-fan/tmp and squashes the following commits:

7ac74d2 [Wenchen Fan] small refactor

1 files changed, 4 insertions, 5 deletions

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
index 1155dac28f..a986dd5387 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
@@ -46,12 +46,11 @@ trait CheckAnalysis {
         operator transformExpressionsUp {
           case a: Attribute if !a.resolved =>
             if (operator.childrenResolved) {
-              val nameParts = a match {
-                case UnresolvedAttribute(nameParts) => nameParts
-                case _ => Seq(a.name)
+              a match {
+                case UnresolvedAttribute(nameParts) =>
+                  // Throw errors for specific problems with get field.
+                  operator.resolveChildren(nameParts, resolver, throwErrors = true)
               }
-              // Throw errors for specific problems with get field.
-              operator.resolveChildren(nameParts, resolver, throwErrors = true)
             }
 
             val from = operator.inputSet.map(_.name).mkString(", ")