aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKaren Feng <karenfeng.us@gmail.com>2013-07-22 15:15:54 -0700
committerKaren Feng <karenfeng.us@gmail.com>2013-07-22 15:15:54 -0700
commit2eea974795dfa2bb79e66496454f36cb499065b0 (patch)
treebee5ea6cc8e6436f75c8ac6ec08a1601a8bb442f
parent85c4d7bf3bf0969f58ebcda6ca68719972ff0c46 (diff)
downloadspark-2eea974795dfa2bb79e66496454f36cb499065b0.tar.gz
spark-2eea974795dfa2bb79e66496454f36cb499065b0.tar.bz2
spark-2eea974795dfa2bb79e66496454f36cb499065b0.zip
Executors UI now calls executor ID from TaskInfo instead of TaskMetrics
-rw-r--r--core/src/main/scala/spark/executor/Executor.scala1
-rw-r--r--core/src/main/scala/spark/executor/TaskMetrics.scala5
-rw-r--r--core/src/main/scala/spark/ui/exec/ExecutorsUI.scala4
3 files changed, 1 insertions, 9 deletions
diff --git a/core/src/main/scala/spark/executor/Executor.scala b/core/src/main/scala/spark/executor/Executor.scala
index 82e5f5a015..2e81151882 100644
--- a/core/src/main/scala/spark/executor/Executor.scala
+++ b/core/src/main/scala/spark/executor/Executor.scala
@@ -126,7 +126,6 @@ private[spark] class Executor(executorId: String, slaveHostname: String, propert
val taskFinish = System.currentTimeMillis()
task.metrics.foreach{ m =>
m.hostname = Utils.localHostName
- m.executorId = executorId
m.executorDeserializeTime = (taskStart - startTime).toInt
m.executorRunTime = (taskFinish - taskStart).toInt
}
diff --git a/core/src/main/scala/spark/executor/TaskMetrics.scala b/core/src/main/scala/spark/executor/TaskMetrics.scala
index e14dc57501..3151627839 100644
--- a/core/src/main/scala/spark/executor/TaskMetrics.scala
+++ b/core/src/main/scala/spark/executor/TaskMetrics.scala
@@ -24,11 +24,6 @@ class TaskMetrics extends Serializable {
var hostname: String = _
/**
- * Executor's ID the task runs on
- */
- var executorId: String = _
-
- /**
* Time taken on the executor to deserialize this task
*/
var executorDeserializeTime: Int = _
diff --git a/core/src/main/scala/spark/ui/exec/ExecutorsUI.scala b/core/src/main/scala/spark/ui/exec/ExecutorsUI.scala
index a981c680d2..40bee325b2 100644
--- a/core/src/main/scala/spark/ui/exec/ExecutorsUI.scala
+++ b/core/src/main/scala/spark/ui/exec/ExecutorsUI.scala
@@ -111,16 +111,14 @@ private[spark] class ExecutorsUI(val sc: SparkContext) {
HashMap[String, ArrayBuffer[(TaskInfo, Option[TaskMetrics], Option[ExceptionFailure])]]()
override def onTaskEnd(taskEnd: SparkListenerTaskEnd) {
- val eid = taskEnd.taskMetrics.executorId
+ val eid = taskEnd.taskInfo.executorId
val (failureInfo, metrics): (Option[ExceptionFailure], Option[TaskMetrics]) =
taskEnd.reason match {
case e: ExceptionFailure =>
executorToTasksFailed(eid) = executorToTasksFailed.getOrElse(eid, 0) + 1
- logInfo("Executor %s has %s failed tasks.".format(eid, executorToTasksFailed(eid)))
(Some(e), e.metrics)
case _ =>
executorToTasksComplete(eid) = executorToTasksComplete.getOrElse(eid, 0) + 1
- logInfo("Executor %s has %s completed tasks.".format(eid, executorToTasksComplete(eid)))
(None, Some(taskEnd.taskMetrics))
}
val taskList = executorToTaskInfos.getOrElse(