aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiangrui Meng <meng@databricks.com>2016-04-09 14:03:03 -0700
committerXiangrui Meng <meng@databricks.com>2016-04-09 14:03:03 -0700
commit415446cc9b2652f6da11ee8ead5eb4e66685c45f (patch)
treeee76f91f1080abc993307315a09697060e0fb948
parentcd2fed70129ba601f8c849a93eeb44a5d69c2402 (diff)
downloadspark-415446cc9b2652f6da11ee8ead5eb4e66685c45f.tar.gz
spark-415446cc9b2652f6da11ee8ead5eb4e66685c45f.tar.bz2
spark-415446cc9b2652f6da11ee8ead5eb4e66685c45f.zip
Revert "[SPARK-14462][ML][MLLIB] add the mllib-local build to maven pom"
This reverts commit 1598d11bb0248384872cf88bc2b16f3b238046ad.
-rw-r--r--dev/sparktestsupport/modules.py14
-rw-r--r--mllib-local/pom.xml94
-rw-r--r--mllib-local/src/main/scala/org/apache/spark/ml/DummyTesting.scala23
-rw-r--r--mllib-local/src/test/scala/org/apache/spark/ml/DummyTestingSuite.scala28
-rw-r--r--mllib/pom.xml12
-rw-r--r--pom.xml1
-rw-r--r--project/SparkBuild.scala6
7 files changed, 4 insertions, 174 deletions
diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py
index c844bcff7e..bb04ec6ee6 100644
--- a/dev/sparktestsupport/modules.py
+++ b/dev/sparktestsupport/modules.py
@@ -256,21 +256,9 @@ streaming_flume_assembly = Module(
)
-mllib_local = Module(
- name="mllib-local",
- dependencies=[],
- source_file_regexes=[
- "mllib-local",
- ],
- sbt_test_goals=[
- "mllib-local/test",
- ]
-)
-
-
mllib = Module(
name="mllib",
- dependencies=[mllib_local, streaming, sql],
+ dependencies=[streaming, sql],
source_file_regexes=[
"data/mllib/",
"mllib/",
diff --git a/mllib-local/pom.xml b/mllib-local/pom.xml
deleted file mode 100644
index 69917eb0fb..0000000000
--- a/mllib-local/pom.xml
+++ /dev/null
@@ -1,94 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
- ~ Licensed to the Apache Software Foundation (ASF) under one or more
- ~ contributor license agreements. See the NOTICE file distributed with
- ~ this work for additional information regarding copyright ownership.
- ~ The ASF licenses this file to You under the Apache License, Version 2.0
- ~ (the "License"); you may not use this file except in compliance with
- ~ the License. You may obtain a copy of the License at
- ~
- ~ http://www.apache.org/licenses/LICENSE-2.0
- ~
- ~ Unless required by applicable law or agreed to in writing, software
- ~ distributed under the License is distributed on an "AS IS" BASIS,
- ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- ~ See the License for the specific language governing permissions and
- ~ limitations under the License.
- -->
-
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-parent_2.11</artifactId>
- <version>2.0.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
- </parent>
-
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-mllib-local_2.11</artifactId>
- <properties>
- <sbt.project.name>mllib-local</sbt.project.name>
- </properties>
- <packaging>jar</packaging>
- <name>Spark Project ML Local Library</name>
- <url>http://spark.apache.org/</url>
-
- <dependencies>
- <dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-core_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <type>test-jar</type>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.scalanlp</groupId>
- <artifactId>breeze_${scala.binary.version}</artifactId>
- <version>0.11.2</version>
- <exclusions>
- <!-- This is included as a compile-scoped dependency by jtransforms, which is
- a dependency of breeze. -->
- <exclusion>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-math3</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-math3</artifactId>
- </dependency>
- <dependency>
- <groupId>org.scalacheck</groupId>
- <artifactId>scalacheck_${scala.binary.version}</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
- <profiles>
- <profile>
- <id>netlib-lgpl</id>
- <dependencies>
- <dependency>
- <groupId>com.github.fommil.netlib</groupId>
- <artifactId>all</artifactId>
- <version>${netlib.java.version}</version>
- <type>pom</type>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
- <build>
- <outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
- <testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
- </build>
-</project>
diff --git a/mllib-local/src/main/scala/org/apache/spark/ml/DummyTesting.scala b/mllib-local/src/main/scala/org/apache/spark/ml/DummyTesting.scala
deleted file mode 100644
index 6b3268cdfa..0000000000
--- a/mllib-local/src/main/scala/org/apache/spark/ml/DummyTesting.scala
+++ /dev/null
@@ -1,23 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.ml
-
-// This is a private class testing if the new build works. To be removed soon.
-private[ml] object DummyTesting {
- private[ml] def add10(input: Double): Double = input + 10
-}
diff --git a/mllib-local/src/test/scala/org/apache/spark/ml/DummyTestingSuite.scala b/mllib-local/src/test/scala/org/apache/spark/ml/DummyTestingSuite.scala
deleted file mode 100644
index 6c76dbfbfa..0000000000
--- a/mllib-local/src/test/scala/org/apache/spark/ml/DummyTestingSuite.scala
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.ml
-
-import org.apache.spark.SparkFunSuite
-
-// This is testing if the new build works. To be removed soon.
-class DummyTestingSuite extends SparkFunSuite {
-
- test("This is testing if the new build works.") {
- assert(DummyTesting.add10(15) === 25)
- }
-}
diff --git a/mllib/pom.xml b/mllib/pom.xml
index e56eafc300..428176dcbf 100644
--- a/mllib/pom.xml
+++ b/mllib/pom.xml
@@ -63,18 +63,6 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-mllib-local_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-mllib-local_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <type>test-jar</type>
- <scope>test</scope>
- </dependency>
- <dependency>
<groupId>org.scalanlp</groupId>
<artifactId>breeze_${scala.binary.version}</artifactId>
<version>0.11.2</version>
diff --git a/pom.xml b/pom.xml
index 58c85b1d36..3f9e4abc32 100644
--- a/pom.xml
+++ b/pom.xml
@@ -94,7 +94,6 @@
<module>core</module>
<module>graphx</module>
<module>mllib</module>
- <module>mllib-local</module>
<module>tools</module>
<module>streaming</module>
<module>sql/catalyst</module>
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index c5688ecec6..60124ef0a1 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -47,9 +47,9 @@ object BuildCommons {
).map(ProjectRef(buildLocation, _))
val allProjects@Seq(
- core, graphx, mllib, mllibLocal, repl, networkCommon, networkShuffle, launcher, unsafe, testTags, sketch, _*
+ core, graphx, mllib, repl, networkCommon, networkShuffle, launcher, unsafe, testTags, sketch, _*
) = Seq(
- "core", "graphx", "mllib", "mllib-local", "repl", "network-common", "network-shuffle", "launcher", "unsafe",
+ "core", "graphx", "mllib", "repl", "network-common", "network-shuffle", "launcher", "unsafe",
"test-tags", "sketch"
).map(ProjectRef(buildLocation, _)) ++ sqlProjects ++ streamingProjects
@@ -254,7 +254,7 @@ object SparkBuild extends PomBuild {
val mimaProjects = allProjects.filterNot { x =>
Seq(
spark, hive, hiveThriftServer, catalyst, repl, networkCommon, networkShuffle, networkYarn,
- unsafe, testTags, sketch, mllibLocal
+ unsafe, testTags, sketch
).contains(x)
}