diff options
| author | Yanbo Liang <ybliang8@gmail.com> | 2015-11-27 11:48:01 -0800 |
|---|---|---|
| committer | Shivaram Venkataraman <shivaram@cs.berkeley.edu> | 2015-11-27 11:48:01 -0800 |
| commit | ba02f6cb5a40511cefa511d410be93c035d43f23 (patch) | |
| tree | ee02c7cff65e95b885d21d5b13c27a4ecd2623ea /R/pkg/inst/tests | |
| parent | a374e20b5492c775f20d32e8fbddadbd8098a655 (diff) | |
| download | spark-ba02f6cb5a40511cefa511d410be93c035d43f23.tar.gz spark-ba02f6cb5a40511cefa511d410be93c035d43f23.tar.bz2 spark-ba02f6cb5a40511cefa511d410be93c035d43f23.zip | |
[SPARK-12025][SPARKR] Rename some window rank function names for SparkR
Change ```cumeDist -> cume_dist, denseRank -> dense_rank, percentRank -> percent_rank, rowNumber -> row_number``` at SparkR side.
There are two reasons that we should make this change:
* We should follow the [naming convention rule of R](http://www.inside-r.org/node/230645)
* Spark DataFrame has deprecated the old convention (such as ```cumeDist```) and will remove it in Spark 2.0.
It's better to fix this issue before 1.6 release, otherwise we will make breaking API change.
cc shivaram sun-rui
Author: Yanbo Liang <ybliang8@gmail.com>
Closes #10016 from yanboliang/SPARK-12025.
Diffstat (limited to 'R/pkg/inst/tests')
| -rw-r--r-- | R/pkg/inst/tests/test_sparkSQL.R | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/R/pkg/inst/tests/test_sparkSQL.R b/R/pkg/inst/tests/test_sparkSQL.R index 3f4f319fe7..0fbe065826 100644 --- a/R/pkg/inst/tests/test_sparkSQL.R +++ b/R/pkg/inst/tests/test_sparkSQL.R @@ -861,8 +861,8 @@ test_that("column functions", { c11 <- to_date(c) + trim(c) + unbase64(c) + unhex(c) + upper(c) c12 <- variance(c) c13 <- lead("col", 1) + lead(c, 1) + lag("col", 1) + lag(c, 1) - c14 <- cumeDist() + ntile(1) - c15 <- denseRank() + percentRank() + rank() + rowNumber() + c14 <- cume_dist() + ntile(1) + c15 <- dense_rank() + percent_rank() + rank() + row_number() # Test if base::rank() is exposed expect_equal(class(rank())[[1]], "Column") |