diff options
| author | Yuhao Yang <yuhao.yang@intel.com> | 2017-04-04 17:51:45 -0700 |
|---|---|---|
| committer | Joseph K. Bradley <joseph@databricks.com> | 2017-04-04 17:51:45 -0700 |
| commit | b28bbffbadf7ebc4349666e8f17111f6fca18c9a (patch) | |
| tree | fd1eea16ecd6599fb1ba984f4b0232024780041d /R/pkg | |
| parent | a59759e6c059617b2fc8102cbf41acc5d409b34a (diff) | |
| download | spark-b28bbffbadf7ebc4349666e8f17111f6fca18c9a.tar.gz spark-b28bbffbadf7ebc4349666e8f17111f6fca18c9a.tar.bz2 spark-b28bbffbadf7ebc4349666e8f17111f6fca18c9a.zip | |
[SPARK-20003][ML] FPGrowthModel setMinConfidence should affect rules generation and transform
## What changes were proposed in this pull request?
jira: https://issues.apache.org/jira/browse/SPARK-20003
I was doing some test and found the issue. ml.fpm.FPGrowthModel `setMinConfidence` should always affect rules generation and transform.
Currently associationRules in FPGrowthModel is a lazy val and `setMinConfidence` in FPGrowthModel has no impact once associationRules got computed .
I try to cache the associationRules to avoid re-computation if `minConfidence` is not changed, but this makes FPGrowthModel somehow stateful. Let me know if there's any concern.
## How was this patch tested?
new unit test and I strength the unit test for model save/load to ensure the cache mechanism.
Author: Yuhao Yang <yuhao.yang@intel.com>
Closes #17336 from hhbyyh/fpmodelminconf.
Diffstat (limited to 'R/pkg')
0 files changed, 0 insertions, 0 deletions