aboutsummaryrefslogtreecommitdiff
path: root/conf
diff options
context:
space:
mode:
authorFelix Cheung <felixcheung_m@hotmail.com>2017-02-14 13:51:27 -0800
committerShivaram Venkataraman <shivaram@cs.berkeley.edu>2017-02-14 13:51:27 -0800
commita3626ca333e6e1881e2f09ccae0fa8fa7243223e (patch)
tree755256c152a2e6340f1ad3578bfaba8518e4a877 /conf
parentab9872db1f9c0f289541ec5756d1a142d85545ce (diff)
downloadspark-a3626ca333e6e1881e2f09ccae0fa8fa7243223e.tar.gz
spark-a3626ca333e6e1881e2f09ccae0fa8fa7243223e.tar.bz2
spark-a3626ca333e6e1881e2f09ccae0fa8fa7243223e.zip
[SPARK-19387][SPARKR] Tests do not run with SparkR source package in CRAN check
## What changes were proposed in this pull request? - this is cause by changes in SPARK-18444, SPARK-18643 that we no longer install Spark when `master = ""` (default), but also related to SPARK-18449 since the real `master` value is not known at the time the R code in `sparkR.session` is run. (`master` cannot default to "local" since it could be overridden by spark-submit commandline or spark config) - as a result, while running SparkR as a package in IDE is working fine, CRAN check is not as it is launching it via non-interactive script - fix is to add check to the beginning of each test and vignettes; the same would also work by changing `sparkR.session()` to `sparkR.session(master = "local")` in tests, but I think being more explicit is better. ## How was this patch tested? Tested this by reverting version to 2.1, since it needs to download the release jar with matching version. But since there are changes in 2.2 (specifically around SparkR ML) that are incompatible with 2.1, some tests are failing in this config. Will need to port this to branch-2.1 and retest with 2.1 release jar. manually as: ``` # modify DESCRIPTION to revert version to 2.1.0 SPARK_HOME=/usr/spark R CMD build pkg # run cran check without SPARK_HOME R CMD check --as-cran SparkR_2.1.0.tar.gz ``` Author: Felix Cheung <felixcheung_m@hotmail.com> Closes #16720 from felixcheung/rcranchecktest.
Diffstat (limited to 'conf')
0 files changed, 0 insertions, 0 deletions