aboutsummaryrefslogtreecommitdiff
path: root/core/src/main
diff options
context:
space:
mode:
authorhyukjinkwon <gurwls223@gmail.com>2017-02-27 08:44:26 +0000
committerSean Owen <sowen@cloudera.com>2017-02-27 08:44:26 +0000
commit4ba9c6c453606f5e5a1e324d5f933d2c9307a604 (patch)
tree1c264800393b03714df7156ec515c2d445849f42 /core/src/main
parent9f8e392159ba65decddf62eb3cd85b6821db01b4 (diff)
downloadspark-4ba9c6c453606f5e5a1e324d5f933d2c9307a604.tar.gz
spark-4ba9c6c453606f5e5a1e324d5f933d2c9307a604.tar.bz2
spark-4ba9c6c453606f5e5a1e324d5f933d2c9307a604.zip
[MINOR][BUILD] Fix lint-java breaks in Java
## What changes were proposed in this pull request? This PR proposes to fix the lint-breaks as below: ``` [ERROR] src/test/java/org/apache/spark/network/TransportResponseHandlerSuite.java:[29,8] (imports) UnusedImports: Unused import - org.apache.spark.network.buffer.ManagedBuffer. [ERROR] src/main/java/org/apache/spark/unsafe/types/UTF8String.java:[156,10] (modifier) ModifierOrder: 'Nonnull' annotation modifier does not precede non-annotation modifiers. [ERROR] src/main/java/org/apache/spark/SparkFirehoseListener.java:[122] (sizes) LineLength: Line is longer than 100 characters (found 105). [ERROR] src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:[164,78] (coding) OneStatementPerLine: Only one statement per line allowed. [ERROR] src/test/java/test/org/apache/spark/JavaAPISuite.java:[1157] (sizes) LineLength: Line is longer than 100 characters (found 121). [ERROR] src/test/java/org/apache/spark/streaming/JavaMapWithStateSuite.java:[149] (sizes) LineLength: Line is longer than 100 characters (found 113). [ERROR] src/test/java/test/org/apache/spark/streaming/Java8APISuite.java:[146] (sizes) LineLength: Line is longer than 100 characters (found 122). [ERROR] src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java:[32,8] (imports) UnusedImports: Unused import - org.apache.spark.streaming.Time. [ERROR] src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java:[611] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/test/org/apache/spark/streaming/JavaAPISuite.java:[1317] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetAggregatorSuite.java:[91] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:[113] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:[164] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:[212] (sizes) LineLength: Line is longer than 100 characters (found 114). [ERROR] src/test/java/org/apache/spark/mllib/tree/JavaDecisionTreeSuite.java:[36] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java:[26,8] (imports) UnusedImports: Unused import - com.amazonaws.regions.RegionUtils. [ERROR] src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java:[20,8] (imports) UnusedImports: Unused import - com.amazonaws.regions.RegionUtils. [ERROR] src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java:[94] (sizes) LineLength: Line is longer than 100 characters (found 103). [ERROR] src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java:[30,8] (imports) UnusedImports: Unused import - org.apache.spark.sql.api.java.UDF1. [ERROR] src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java:[72] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/main/java/org/apache/spark/examples/mllib/JavaRankingMetricsExample.java:[121] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/main/java/org/apache/spark/examples/sql/JavaSQLDataSourceExample.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.api.java.JavaRDD. [ERROR] src/main/java/org/apache/spark/examples/sql/JavaSQLDataSourceExample.java:[29,8] (imports) UnusedImports: Unused import - org.apache.spark.api.java.JavaSparkContext. ``` ## How was this patch tested? Manually via ```bash ./dev/lint-java ``` Author: hyukjinkwon <gurwls223@gmail.com> Closes #17072 from HyukjinKwon/java-lint.
Diffstat (limited to 'core/src/main')
-rw-r--r--core/src/main/java/org/apache/spark/SparkFirehoseListener.java225
-rw-r--r--core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java4
2 files changed, 116 insertions, 113 deletions
diff --git a/core/src/main/java/org/apache/spark/SparkFirehoseListener.java b/core/src/main/java/org/apache/spark/SparkFirehoseListener.java
index 9fe97b4d9c..140c52fd12 100644
--- a/core/src/main/java/org/apache/spark/SparkFirehoseListener.java
+++ b/core/src/main/java/org/apache/spark/SparkFirehoseListener.java
@@ -30,116 +30,117 @@ import org.apache.spark.scheduler.*;
*/
public class SparkFirehoseListener implements SparkListenerInterface {
- public void onEvent(SparkListenerEvent event) { }
-
- @Override
- public final void onStageCompleted(SparkListenerStageCompleted stageCompleted) {
- onEvent(stageCompleted);
- }
-
- @Override
- public final void onStageSubmitted(SparkListenerStageSubmitted stageSubmitted) {
- onEvent(stageSubmitted);
- }
-
- @Override
- public final void onTaskStart(SparkListenerTaskStart taskStart) {
- onEvent(taskStart);
- }
-
- @Override
- public final void onTaskGettingResult(SparkListenerTaskGettingResult taskGettingResult) {
- onEvent(taskGettingResult);
- }
-
- @Override
- public final void onTaskEnd(SparkListenerTaskEnd taskEnd) {
- onEvent(taskEnd);
- }
-
- @Override
- public final void onJobStart(SparkListenerJobStart jobStart) {
- onEvent(jobStart);
- }
-
- @Override
- public final void onJobEnd(SparkListenerJobEnd jobEnd) {
- onEvent(jobEnd);
- }
-
- @Override
- public final void onEnvironmentUpdate(SparkListenerEnvironmentUpdate environmentUpdate) {
- onEvent(environmentUpdate);
- }
-
- @Override
- public final void onBlockManagerAdded(SparkListenerBlockManagerAdded blockManagerAdded) {
- onEvent(blockManagerAdded);
- }
-
- @Override
- public final void onBlockManagerRemoved(SparkListenerBlockManagerRemoved blockManagerRemoved) {
- onEvent(blockManagerRemoved);
- }
-
- @Override
- public final void onUnpersistRDD(SparkListenerUnpersistRDD unpersistRDD) {
- onEvent(unpersistRDD);
- }
-
- @Override
- public final void onApplicationStart(SparkListenerApplicationStart applicationStart) {
- onEvent(applicationStart);
- }
-
- @Override
- public final void onApplicationEnd(SparkListenerApplicationEnd applicationEnd) {
- onEvent(applicationEnd);
- }
-
- @Override
- public final void onExecutorMetricsUpdate(
- SparkListenerExecutorMetricsUpdate executorMetricsUpdate) {
- onEvent(executorMetricsUpdate);
- }
-
- @Override
- public final void onExecutorAdded(SparkListenerExecutorAdded executorAdded) {
- onEvent(executorAdded);
- }
-
- @Override
- public final void onExecutorRemoved(SparkListenerExecutorRemoved executorRemoved) {
- onEvent(executorRemoved);
- }
-
- @Override
- public final void onExecutorBlacklisted(SparkListenerExecutorBlacklisted executorBlacklisted) {
- onEvent(executorBlacklisted);
- }
-
- @Override
- public final void onExecutorUnblacklisted(SparkListenerExecutorUnblacklisted executorUnblacklisted) {
- onEvent(executorUnblacklisted);
- }
-
- @Override
- public final void onNodeBlacklisted(SparkListenerNodeBlacklisted nodeBlacklisted) {
- onEvent(nodeBlacklisted);
- }
-
- @Override
- public final void onNodeUnblacklisted(SparkListenerNodeUnblacklisted nodeUnblacklisted) {
- onEvent(nodeUnblacklisted);
- }
-
- @Override
- public void onBlockUpdated(SparkListenerBlockUpdated blockUpdated) {
- onEvent(blockUpdated);
- }
-
- @Override
- public void onOtherEvent(SparkListenerEvent event) {
- onEvent(event);
- }
+ public void onEvent(SparkListenerEvent event) { }
+
+ @Override
+ public final void onStageCompleted(SparkListenerStageCompleted stageCompleted) {
+ onEvent(stageCompleted);
+ }
+
+ @Override
+ public final void onStageSubmitted(SparkListenerStageSubmitted stageSubmitted) {
+ onEvent(stageSubmitted);
+ }
+
+ @Override
+ public final void onTaskStart(SparkListenerTaskStart taskStart) {
+ onEvent(taskStart);
+ }
+
+ @Override
+ public final void onTaskGettingResult(SparkListenerTaskGettingResult taskGettingResult) {
+ onEvent(taskGettingResult);
+ }
+
+ @Override
+ public final void onTaskEnd(SparkListenerTaskEnd taskEnd) {
+ onEvent(taskEnd);
+ }
+
+ @Override
+ public final void onJobStart(SparkListenerJobStart jobStart) {
+ onEvent(jobStart);
+ }
+
+ @Override
+ public final void onJobEnd(SparkListenerJobEnd jobEnd) {
+ onEvent(jobEnd);
+ }
+
+ @Override
+ public final void onEnvironmentUpdate(SparkListenerEnvironmentUpdate environmentUpdate) {
+ onEvent(environmentUpdate);
+ }
+
+ @Override
+ public final void onBlockManagerAdded(SparkListenerBlockManagerAdded blockManagerAdded) {
+ onEvent(blockManagerAdded);
+ }
+
+ @Override
+ public final void onBlockManagerRemoved(SparkListenerBlockManagerRemoved blockManagerRemoved) {
+ onEvent(blockManagerRemoved);
+ }
+
+ @Override
+ public final void onUnpersistRDD(SparkListenerUnpersistRDD unpersistRDD) {
+ onEvent(unpersistRDD);
+ }
+
+ @Override
+ public final void onApplicationStart(SparkListenerApplicationStart applicationStart) {
+ onEvent(applicationStart);
+ }
+
+ @Override
+ public final void onApplicationEnd(SparkListenerApplicationEnd applicationEnd) {
+ onEvent(applicationEnd);
+ }
+
+ @Override
+ public final void onExecutorMetricsUpdate(
+ SparkListenerExecutorMetricsUpdate executorMetricsUpdate) {
+ onEvent(executorMetricsUpdate);
+ }
+
+ @Override
+ public final void onExecutorAdded(SparkListenerExecutorAdded executorAdded) {
+ onEvent(executorAdded);
+ }
+
+ @Override
+ public final void onExecutorRemoved(SparkListenerExecutorRemoved executorRemoved) {
+ onEvent(executorRemoved);
+ }
+
+ @Override
+ public final void onExecutorBlacklisted(SparkListenerExecutorBlacklisted executorBlacklisted) {
+ onEvent(executorBlacklisted);
+ }
+
+ @Override
+ public final void onExecutorUnblacklisted(
+ SparkListenerExecutorUnblacklisted executorUnblacklisted) {
+ onEvent(executorUnblacklisted);
+ }
+
+ @Override
+ public final void onNodeBlacklisted(SparkListenerNodeBlacklisted nodeBlacklisted) {
+ onEvent(nodeBlacklisted);
+ }
+
+ @Override
+ public final void onNodeUnblacklisted(SparkListenerNodeUnblacklisted nodeUnblacklisted) {
+ onEvent(nodeUnblacklisted);
+ }
+
+ @Override
+ public void onBlockUpdated(SparkListenerBlockUpdated blockUpdated) {
+ onEvent(blockUpdated);
+ }
+
+ @Override
+ public void onOtherEvent(SparkListenerEvent event) {
+ onEvent(event);
+ }
}
diff --git a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
index 29aca04a3d..f312fa2b2d 100644
--- a/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
+++ b/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
@@ -161,7 +161,9 @@ public final class UnsafeExternalSorter extends MemoryConsumer {
// Register a cleanup task with TaskContext to ensure that memory is guaranteed to be freed at
// the end of the task. This is necessary to avoid memory leaks in when the downstream operator
// does not fully consume the sorter's output (e.g. sort followed by limit).
- taskContext.addTaskCompletionListener(context -> { cleanupResources(); });
+ taskContext.addTaskCompletionListener(context -> {
+ cleanupResources();
+ });
}
/**