aboutsummaryrefslogtreecommitdiff
path: root/core/src
diff options
context:
space:
mode:
authorDavies Liu <davies.liu@gmail.com>2016-06-15 15:55:07 -0700
committerDavies Liu <davies.liu@gmail.com>2016-06-15 15:55:07 -0700
commita153e41c08b635b1b2a48b680d203c148deebc67 (patch)
tree552e2dc3e9146662f523f7eb3495fe0a1607b8f3 /core/src
parent1a33f2e05c8813ce1ff94e10d0c03fc7e5c403ce (diff)
downloadspark-a153e41c08b635b1b2a48b680d203c148deebc67.tar.gz
spark-a153e41c08b635b1b2a48b680d203c148deebc67.tar.bz2
spark-a153e41c08b635b1b2a48b680d203c148deebc67.zip
Revert "[SPARK-15782][YARN] Set spark.jars system property in client mode"
This reverts commit 4df8df5c2e68f5a5d231c401b04d762d7a648159.
Diffstat (limited to 'core/src')
-rw-r--r--core/src/main/scala/org/apache/spark/SparkContext.scala2
-rw-r--r--core/src/main/scala/org/apache/spark/util/Utils.scala20
-rw-r--r--core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala12
3 files changed, 1 insertions, 33 deletions
diff --git a/core/src/main/scala/org/apache/spark/SparkContext.scala b/core/src/main/scala/org/apache/spark/SparkContext.scala
index d8701812eb..d56946e932 100644
--- a/core/src/main/scala/org/apache/spark/SparkContext.scala
+++ b/core/src/main/scala/org/apache/spark/SparkContext.scala
@@ -391,7 +391,7 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
_conf.set("spark.executor.id", SparkContext.DRIVER_IDENTIFIER)
- _jars = Utils.getUserJars(_conf)
+ _jars = _conf.getOption("spark.jars").map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
_files = _conf.getOption("spark.files").map(_.split(",")).map(_.filter(_.nonEmpty))
.toSeq.flatten
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala
index aebd98b3b0..f9d05409e1 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -2352,26 +2352,6 @@ private[spark] object Utils extends Logging {
log.info(s"Started daemon with process name: ${Utils.getProcessName()}")
SignalUtils.registerLogger(log)
}
-
- /**
- * Unions two comma-separated lists of files and filters out empty strings.
- */
- def unionFileLists(leftList: Option[String], rightList: Option[String]): Set[String] = {
- var allFiles = Set[String]()
- leftList.foreach { value => allFiles ++= value.split(",") }
- rightList.foreach { value => allFiles ++= value.split(",") }
- allFiles.filter { _.nonEmpty }
- }
-
- def getUserJars(conf: SparkConf): Seq[String] = {
- val sparkJars = conf.getOption("spark.jars")
- if (conf.get("spark.master") == "yarn") {
- val yarnJars = conf.getOption("spark.yarn.dist.jars")
- unionFileLists(sparkJars, yarnJars).toSeq
- } else {
- sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
- }
- }
}
/**
diff --git a/core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala b/core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
index 0b020592b0..2718976992 100644
--- a/core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
+++ b/core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
@@ -570,18 +570,6 @@ class SparkSubmitSuite
appArgs.executorMemory should be ("2.3g")
}
}
-
- test("comma separated list of files are unioned correctly") {
- val left = Option("/tmp/a.jar,/tmp/b.jar")
- val right = Option("/tmp/c.jar,/tmp/a.jar")
- val emptyString = Option("")
- Utils.unionFileLists(left, right) should be (Set("/tmp/a.jar", "/tmp/b.jar", "/tmp/c.jar"))
- Utils.unionFileLists(emptyString, emptyString) should be (Set.empty)
- Utils.unionFileLists(Option("/tmp/a.jar"), emptyString) should be (Set("/tmp/a.jar"))
- Utils.unionFileLists(emptyString, Option("/tmp/a.jar")) should be (Set("/tmp/a.jar"))
- Utils.unionFileLists(None, Option("/tmp/a.jar")) should be (Set("/tmp/a.jar"))
- Utils.unionFileLists(Option("/tmp/a.jar"), None) should be (Set("/tmp/a.jar"))
- }
// scalastyle:on println
// NOTE: This is an expensive operation in terms of time (10 seconds+). Use sparingly.