diff options
| author | Drew Robb <drewrobb@gmail.com> | 2016-10-22 01:59:36 -0700 |
|---|---|---|
| committer | Yanbo Liang <ybliang8@gmail.com> | 2016-10-22 01:59:36 -0700 |
| commit | ab3363e9f6b1f7fc26682509fe7382c570f91778 (patch) | |
| tree | 051346a15d581c1fab21ef3e0e380ebbcb91b693 /core/src | |
| parent | 01b26a06436b4c8020f22be3e1da4995b44c9b03 (diff) | |
| download | spark-ab3363e9f6b1f7fc26682509fe7382c570f91778.tar.gz spark-ab3363e9f6b1f7fc26682509fe7382c570f91778.tar.bz2 spark-ab3363e9f6b1f7fc26682509fe7382c570f91778.zip | |
[SPARK-17986][ML] SQLTransformer should remove temporary tables
## What changes were proposed in this pull request?
A call to the method `SQLTransformer.transform` previously would create a temporary table and never delete it. This change adds a call to `dropTempView()` that deletes this temporary table before returning the result so that the table will not remain in spark's table catalog. Because `tableName` is randomized and not exposed, there should be no expected use of this table outside of the `transform` method.
## How was this patch tested?
A single new assertion was added to the existing test of the `SQLTransformer.transform` method that all temporary tables are removed. Without the corresponding code change, this new assertion fails. I am not aware of any circumstances in which removing this temporary view would be bad for performance or correctness in other ways, but some expertise here would be helpful.
Author: Drew Robb <drewrobb@gmail.com>
Closes #15526 from drewrobb/SPARK-17986.
Diffstat (limited to 'core/src')
0 files changed, 0 insertions, 0 deletions