diff options
| author | Jakob Odersky <jodersky@gmail.com> | 2015-10-20 08:54:34 +0100 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2015-10-20 08:54:34 +0100 |
| commit | 60851bc7bf1fe702cde1d1548efd8016411e1682 (patch) | |
| tree | 6c470899d1a72bccddd4d5e9ed557a7fcf48935d /core | |
| parent | 8f74aa639759f400120794355511327fa74905da (diff) | |
| download | spark-60851bc7bf1fe702cde1d1548efd8016411e1682.tar.gz spark-60851bc7bf1fe702cde1d1548efd8016411e1682.tar.bz2 spark-60851bc7bf1fe702cde1d1548efd8016411e1682.zip | |
[SPARK-11110][BUILD] Remove transient annotation for parameters.
`transient` annotations on class parameters (not case class parameters or vals) causes compilation errors during compilation with Scala 2.11.
I understand that transient *parameters* make no sense, however I don't quite understand why the 2.10 compiler accepted them.
Note: in case it is preferred to keep the annotations in case someone would in the future want to redefine them as vals, it would also be possible to just add `val` after the annotation, e.g. `class Foo(transient x: Int)` becomes `class Foo(transient private val x: Int)`.
I chose to remove the annotation as it also reduces needles clutter, however please feel free to tell me if you prefer the second option and I'll update the PR
Author: Jakob Odersky <jodersky@gmail.com>
Closes #9126 from jodersky/sbt-scala-2.11.
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala b/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala index a2b28c524d..e01cf1a29e 100644 --- a/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala +++ b/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala @@ -308,7 +308,7 @@ private[netty] class NettyRpcEnvFactory extends RpcEnvFactory with Logging { } } -private[netty] class NettyRpcEndpointRef(@transient conf: SparkConf) +private[netty] class NettyRpcEndpointRef(@transient private val conf: SparkConf) extends RpcEndpointRef(conf) with Serializable with Logging { @transient @volatile private var nettyEnv: NettyRpcEnv = _ |