diff options
| author | Sandeep Singh <sandeep@techaddict.me> | 2016-05-07 11:10:14 +0800 |
|---|---|---|
| committer | Wenchen Fan <wenchen@databricks.com> | 2016-05-07 11:10:14 +0800 |
| commit | a21a3bbe6931e162c53a61daff1ef428fb802b8a (patch) | |
| tree | ac851821be5a655ffb2de35c85e075498556ccfb /core | |
| parent | cc95f1ed5fdf2566bcefe8d10116eee544cf9184 (diff) | |
| download | spark-a21a3bbe6931e162c53a61daff1ef428fb802b8a.tar.gz spark-a21a3bbe6931e162c53a61daff1ef428fb802b8a.tar.bz2 spark-a21a3bbe6931e162c53a61daff1ef428fb802b8a.zip | |
[SPARK-15087][MINOR][DOC] Follow Up: Fix the Comments
## What changes were proposed in this pull request?
Remove the Comment, since it not longer applies. see the discussion here(https://github.com/apache/spark/pull/12865#discussion-diff-61946906)
Author: Sandeep Singh <sandeep@techaddict.me>
Closes #12953 from techaddict/SPARK-15087-FOLLOW-UP.
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala index 8ce8fb15ef..371fb8602f 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala @@ -389,11 +389,6 @@ private[spark] class TaskSchedulerImpl( // (taskId, stageId, stageAttemptId, accumUpdates) val accumUpdatesWithTaskIds: Array[(Long, Int, Int, Seq[AccumulableInfo])] = synchronized { accumUpdates.flatMap { case (id, updates) => - // We should call `acc.value` here as we are at driver side now. However, the RPC framework - // optimizes local message delivery so that messages do not need to de serialized and - // deserialized. This brings trouble to the accumulator framework, which depends on - // serialization to set the `atDriverSide` flag. Here we call `acc.localValue` instead to - // be more robust about this issue. val accInfos = updates.map(acc => acc.toInfo(Some(acc.value), None)) taskIdToTaskSetManager.get(id).map { taskSetMgr => (id, taskSetMgr.stageId, taskSetMgr.taskSet.stageAttemptId, accInfos) |