aboutsummaryrefslogtreecommitdiff
path: root/dev/merge_spark_pr.py
diff options
context:
space:
mode:
authorJosh Rosen <joshrosen@databricks.com>2015-06-26 08:12:22 -0700
committerDavies Liu <davies@databricks.com>2015-06-26 08:12:22 -0700
commit41afa16500e682475eaa80e31c0434b7ab66abcb (patch)
tree298d6e9e0739fa91a99422c1308eb15ff6ad12f3 /dev/merge_spark_pr.py
parent37bf76a2de2143ec6348a3d43b782227849520cc (diff)
downloadspark-41afa16500e682475eaa80e31c0434b7ab66abcb.tar.gz
spark-41afa16500e682475eaa80e31c0434b7ab66abcb.tar.bz2
spark-41afa16500e682475eaa80e31c0434b7ab66abcb.zip
[SPARK-8652] [PYSPARK] Check return value for all uses of doctest.testmod()
This patch addresses a critical issue in the PySpark tests: Several of our Python modules' `__main__` methods call `doctest.testmod()` in order to run doctests but forget to check and handle its return value. As a result, some PySpark test failures can go unnoticed because they will not fail the build. Fortunately, there was only one test failure which was masked by this bug: a `pyspark.profiler` doctest was failing due to changes in RDD pipelining. Author: Josh Rosen <joshrosen@databricks.com> Closes #7032 from JoshRosen/testmod-fix and squashes the following commits: 60dbdc0 [Josh Rosen] Account for int vs. long formatting change in Python 3 8b8d80a [Josh Rosen] Fix failing test. e6423f9 [Josh Rosen] Check return code for all uses of doctest.testmod().
Diffstat (limited to 'dev/merge_spark_pr.py')
-rwxr-xr-xdev/merge_spark_pr.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/dev/merge_spark_pr.py b/dev/merge_spark_pr.py
index cd83b352c1..cf827ce89b 100755
--- a/dev/merge_spark_pr.py
+++ b/dev/merge_spark_pr.py
@@ -431,6 +431,8 @@ def main():
if __name__ == "__main__":
import doctest
- doctest.testmod()
+ (failure_count, test_count) = doctest.testmod()
+ if failure_count:
+ exit(-1)
main()