aboutsummaryrefslogtreecommitdiff
path: root/dev
diff options
context:
space:
mode:
authorMarcelo Vanzin <vanzin@cloudera.com>2015-09-15 13:03:38 -0700
committerMarcelo Vanzin <vanzin@cloudera.com>2015-09-15 13:03:38 -0700
commitb42059d2efdf3322334694205a6d951bcc291644 (patch)
tree551ffe50ef6df7b3c0fe1d9b2f66049a8eac9487 /dev
parent416003b26401894ec712e1a5291a92adfbc5af01 (diff)
downloadspark-b42059d2efdf3322334694205a6d951bcc291644.tar.gz
spark-b42059d2efdf3322334694205a6d951bcc291644.tar.bz2
spark-b42059d2efdf3322334694205a6d951bcc291644.zip
Revert "[SPARK-10300] [BUILD] [TESTS] Add support for test tags in run-tests.py."
This reverts commit 8abef21dac1a6538c4e4e0140323b83d804d602b.
Diffstat (limited to 'dev')
-rwxr-xr-xdev/run-tests.py19
-rw-r--r--dev/sparktestsupport/modules.py24
2 files changed, 3 insertions, 40 deletions
diff --git a/dev/run-tests.py b/dev/run-tests.py
index 1a81658518..d8b22e1665 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -118,14 +118,6 @@ def determine_modules_to_test(changed_modules):
return modules_to_test.union(set(changed_modules))
-def determine_tags_to_exclude(changed_modules):
- tags = []
- for m in modules.all_modules:
- if m not in changed_modules:
- tags += m.test_tags
- return tags
-
-
# -------------------------------------------------------------------------------------------------
# Functions for working with subprocesses and shell tools
# -------------------------------------------------------------------------------------------------
@@ -377,7 +369,6 @@ def detect_binary_inop_with_mima():
def run_scala_tests_maven(test_profiles):
mvn_test_goals = ["test", "--fail-at-end"]
-
profiles_and_goals = test_profiles + mvn_test_goals
print("[info] Running Spark tests using Maven with these arguments: ",
@@ -401,7 +392,7 @@ def run_scala_tests_sbt(test_modules, test_profiles):
exec_sbt(profiles_and_goals)
-def run_scala_tests(build_tool, hadoop_version, test_modules, excluded_tags):
+def run_scala_tests(build_tool, hadoop_version, test_modules):
"""Function to properly execute all tests passed in as a set from the
`determine_test_suites` function"""
set_title_and_block("Running Spark unit tests", "BLOCK_SPARK_UNIT_TESTS")
@@ -410,10 +401,6 @@ def run_scala_tests(build_tool, hadoop_version, test_modules, excluded_tags):
test_profiles = get_hadoop_profiles(hadoop_version) + \
list(set(itertools.chain.from_iterable(m.build_profile_flags for m in test_modules)))
-
- if excluded_tags:
- test_profiles += ['-Dtest.exclude.tags=' + ",".join(excluded_tags)]
-
if build_tool == "maven":
run_scala_tests_maven(test_profiles)
else:
@@ -513,10 +500,8 @@ def main():
target_branch = os.environ["ghprbTargetBranch"]
changed_files = identify_changed_files_from_git_commits("HEAD", target_branch=target_branch)
changed_modules = determine_modules_for_files(changed_files)
- excluded_tags = determine_tags_to_exclude(changed_modules)
if not changed_modules:
changed_modules = [modules.root]
- excluded_tags = []
print("[info] Found the following changed modules:",
", ".join(x.name for x in changed_modules))
@@ -556,7 +541,7 @@ def main():
detect_binary_inop_with_mima()
# run the test suites
- run_scala_tests(build_tool, hadoop_version, test_modules, excluded_tags)
+ run_scala_tests(build_tool, hadoop_version, test_modules)
modules_with_python_tests = [m for m in test_modules if m.python_test_goals]
if modules_with_python_tests:
diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py
index 65397f1f3e..346452f317 100644
--- a/dev/sparktestsupport/modules.py
+++ b/dev/sparktestsupport/modules.py
@@ -31,7 +31,7 @@ class Module(object):
def __init__(self, name, dependencies, source_file_regexes, build_profile_flags=(), environ={},
sbt_test_goals=(), python_test_goals=(), blacklisted_python_implementations=(),
- test_tags=(), should_run_r_tests=False):
+ should_run_r_tests=False):
"""
Define a new module.
@@ -50,8 +50,6 @@ class Module(object):
:param blacklisted_python_implementations: A set of Python implementations that are not
supported by this module's Python components. The values in this set should match
strings returned by Python's `platform.python_implementation()`.
- :param test_tags A set of tags that will be excluded when running unit tests if the module
- is not explicitly changed.
:param should_run_r_tests: If true, changes in this module will trigger all R tests.
"""
self.name = name
@@ -62,7 +60,6 @@ class Module(object):
self.environ = environ
self.python_test_goals = python_test_goals
self.blacklisted_python_implementations = blacklisted_python_implementations
- self.test_tags = test_tags
self.should_run_r_tests = should_run_r_tests
self.dependent_modules = set()
@@ -88,9 +85,6 @@ sql = Module(
"catalyst/test",
"sql/test",
"hive/test",
- ],
- test_tags=[
- "org.apache.spark.sql.hive.ExtendedHiveTest"
]
)
@@ -404,22 +398,6 @@ ec2 = Module(
)
-yarn = Module(
- name="yarn",
- dependencies=[],
- source_file_regexes=[
- "yarn/",
- "network/yarn/",
- ],
- sbt_test_goals=[
- "yarn/test",
- "network-yarn/test",
- ],
- test_tags=[
- "org.apache.spark.deploy.yarn.ExtendedYarnTest"
- ]
-)
-
# The root module is a dummy module which is used to run all of the tests.
# No other modules should directly depend on this module.
root = Module(