diff options
| author | Sean Owen <srowen@gmail.com> | 2014-07-30 15:04:33 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@apache.org> | 2014-07-30 15:04:33 -0700 |
| commit | 6ab96a6fd0db7731c8c5d6478d9e28b619581687 (patch) | |
| tree | 6eaad2457557d5ff3345e291af69361f1c154611 /external/flume | |
| parent | 2f4b17056fdcba26fd3a7503b858364b883ab0b0 (diff) | |
| download | spark-6ab96a6fd0db7731c8c5d6478d9e28b619581687.tar.gz spark-6ab96a6fd0db7731c8c5d6478d9e28b619581687.tar.bz2 spark-6ab96a6fd0db7731c8c5d6478d9e28b619581687.zip | |
SPARK-2749 [BUILD]. Spark SQL Java tests aren't compiling in Jenkins' Maven builds; missing junit:junit dep
The Maven-based builds in the build matrix have been failing for a few days:
https://amplab.cs.berkeley.edu/jenkins/view/Spark/
On inspection, it looks like the Spark SQL Java tests don't compile:
https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-Master-Maven-pre-YARN/hadoop.version=1.0.4,label=centos/244/consoleFull
I confirmed it by repeating the command vs master:
`mvn -Dhadoop.version=1.0.4 -Dlabel=centos -DskipTests clean package`
The problem is that this module doesn't depend on JUnit. In fact, none of the modules do, but `com.novocode:junit-interface` (the SBT-JUnit bridge) pulls it in, in most places. However this module doesn't depend on `com.novocode:junit-interface`
Adding the `junit:junit` dependency fixes the compile problem. In fact, the other modules with Java tests should probably depend on it explicitly instead of happening to get it via `com.novocode:junit-interface`, since that is a bit SBT/Scala-specific (and I am not even sure it's needed).
Author: Sean Owen <srowen@gmail.com>
Closes #1660 from srowen/SPARK-2749 and squashes the following commits:
858ff7c [Sean Owen] Add explicit junit dep to other modules with Java tests for robustness
9636794 [Sean Owen] Add junit dep so that Spark SQL Java tests compile
Diffstat (limited to 'external/flume')
| -rw-r--r-- | external/flume/pom.xml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/external/flume/pom.xml b/external/flume/pom.xml index 9f680b27c3..c532705f39 100644 --- a/external/flume/pom.xml +++ b/external/flume/pom.xml @@ -73,6 +73,11 @@ <scope>test</scope> </dependency> <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <scope>test</scope> + </dependency> + <dependency> <groupId>com.novocode</groupId> <artifactId>junit-interface</artifactId> <scope>test</scope> |