diff options
author | Xin Ren <iamshrek@126.com> | 2016-07-19 11:59:46 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2016-07-19 11:59:46 +0100 |
commit | 21a6dd2aef65a23d92f93c43fa731c0505250363 (patch) | |
tree | 8a5590b9b3200a2263d2279ba3e0d0350b48a198 /external | |
parent | 556a9437ac7b55079f5a8a91e669dcc36ca02696 (diff) | |
download | spark-21a6dd2aef65a23d92f93c43fa731c0505250363.tar.gz spark-21a6dd2aef65a23d92f93c43fa731c0505250363.tar.bz2 spark-21a6dd2aef65a23d92f93c43fa731c0505250363.zip |
[SPARK-16535][BUILD] In pom.xml, remove groupId which is redundant definition and inherited from the parent
https://issues.apache.org/jira/browse/SPARK-16535
## What changes were proposed in this pull request?
When I scan through the pom.xml of sub projects, I found this warning as below and attached screenshot
```
Definition of groupId is redundant, because it's inherited from the parent
```
![screen shot 2016-07-13 at 3 13 11 pm](https://cloud.githubusercontent.com/assets/3925641/16823121/744f893e-4916-11e6-8a52-042f83b9db4e.png)
I've tried to remove some of the lines with groupId definition, and the build on my local machine is still ok.
```
<groupId>org.apache.spark</groupId>
```
As I just find now `<maven.version>3.3.9</maven.version>` is being used in Spark 2.x, and Maven-3 supports versionless parent elements: Maven 3 will remove the need to specify the parent version in sub modules. THIS is great (in Maven 3.1).
ref: http://stackoverflow.com/questions/3157240/maven-3-worth-it/3166762#3166762
## How was this patch tested?
I've tested by re-building the project, and build succeeded.
Author: Xin Ren <iamshrek@126.com>
Closes #14189 from keypointt/SPARK-16535.
Diffstat (limited to 'external')
-rw-r--r-- | external/flume-assembly/pom.xml | 1 | ||||
-rw-r--r-- | external/flume-sink/pom.xml | 1 | ||||
-rw-r--r-- | external/flume/pom.xml | 1 | ||||
-rw-r--r-- | external/java8-tests/pom.xml | 1 | ||||
-rw-r--r-- | external/kafka-0-10-assembly/pom.xml | 1 | ||||
-rw-r--r-- | external/kafka-0-10/pom.xml | 1 | ||||
-rw-r--r-- | external/kafka-0-8-assembly/pom.xml | 1 | ||||
-rw-r--r-- | external/kafka-0-8/pom.xml | 1 | ||||
-rw-r--r-- | external/kinesis-asl-assembly/pom.xml | 1 | ||||
-rw-r--r-- | external/kinesis-asl/pom.xml | 1 | ||||
-rw-r--r-- | external/spark-ganglia-lgpl/pom.xml | 1 |
11 files changed, 0 insertions, 11 deletions
diff --git a/external/flume-assembly/pom.xml b/external/flume-assembly/pom.xml index 9e0636e63b..fb0292a5f1 100644 --- a/external/flume-assembly/pom.xml +++ b/external/flume-assembly/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-flume-assembly_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project External Flume Assembly</name> diff --git a/external/flume-sink/pom.xml b/external/flume-sink/pom.xml index 6b788d7da3..5e9275c8e6 100644 --- a/external/flume-sink/pom.xml +++ b/external/flume-sink/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-flume-sink_2.11</artifactId> <properties> <sbt.project.name>streaming-flume-sink</sbt.project.name> diff --git a/external/flume/pom.xml b/external/flume/pom.xml index 1b1105d763..7b68ca7373 100644 --- a/external/flume/pom.xml +++ b/external/flume/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-flume_2.11</artifactId> <properties> <sbt.project.name>streaming-flume</sbt.project.name> diff --git a/external/java8-tests/pom.xml b/external/java8-tests/pom.xml index a092393290..1bc206e867 100644 --- a/external/java8-tests/pom.xml +++ b/external/java8-tests/pom.xml @@ -24,7 +24,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>java8-tests_2.11</artifactId> <packaging>pom</packaging> <name>Spark Project Java 8 Tests</name> diff --git a/external/kafka-0-10-assembly/pom.xml b/external/kafka-0-10-assembly/pom.xml index 6c1a120c5e..4f5045326a 100644 --- a/external/kafka-0-10-assembly/pom.xml +++ b/external/kafka-0-10-assembly/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kafka-0-10-assembly_2.11</artifactId> <packaging>jar</packaging> <name>Spark Integration for Kafka 0.10 Assembly</name> diff --git a/external/kafka-0-10/pom.xml b/external/kafka-0-10/pom.xml index b38de96cd5..60afaa582b 100644 --- a/external/kafka-0-10/pom.xml +++ b/external/kafka-0-10/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kafka-0-10_2.11</artifactId> <properties> <sbt.project.name>streaming-kafka-0-10</sbt.project.name> diff --git a/external/kafka-0-8-assembly/pom.xml b/external/kafka-0-8-assembly/pom.xml index 4839ed4f42..bc02b8a662 100644 --- a/external/kafka-0-8-assembly/pom.xml +++ b/external/kafka-0-8-assembly/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kafka-0-8-assembly_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project External Kafka Assembly</name> diff --git a/external/kafka-0-8/pom.xml b/external/kafka-0-8/pom.xml index 948b9f500a..91ccd4a927 100644 --- a/external/kafka-0-8/pom.xml +++ b/external/kafka-0-8/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kafka-0-8_2.11</artifactId> <properties> <sbt.project.name>streaming-kafka-0-8</sbt.project.name> diff --git a/external/kinesis-asl-assembly/pom.xml b/external/kinesis-asl-assembly/pom.xml index 09ca2c3aac..df528b3598 100644 --- a/external/kinesis-asl-assembly/pom.xml +++ b/external/kinesis-asl-assembly/pom.xml @@ -25,7 +25,6 @@ <relativePath>../../pom.xml</relativePath> </parent> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kinesis-asl-assembly_2.11</artifactId> <packaging>jar</packaging> <name>Spark Project Kinesis Assembly</name> diff --git a/external/kinesis-asl/pom.xml b/external/kinesis-asl/pom.xml index 3bb80343f0..57809ff692 100644 --- a/external/kinesis-asl/pom.xml +++ b/external/kinesis-asl/pom.xml @@ -25,7 +25,6 @@ </parent> <!-- Kinesis integration is not included by default due to ASL-licensed code. --> - <groupId>org.apache.spark</groupId> <artifactId>spark-streaming-kinesis-asl_2.11</artifactId> <packaging>jar</packaging> <name>Spark Kinesis Integration</name> diff --git a/external/spark-ganglia-lgpl/pom.xml b/external/spark-ganglia-lgpl/pom.xml index 34cbd9a620..fab409d3e9 100644 --- a/external/spark-ganglia-lgpl/pom.xml +++ b/external/spark-ganglia-lgpl/pom.xml @@ -25,7 +25,6 @@ </parent> <!-- Ganglia integration is not included by default due to LGPL-licensed code --> - <groupId>org.apache.spark</groupId> <artifactId>spark-ganglia-lgpl_2.11</artifactId> <packaging>jar</packaging> <name>Spark Ganglia Integration</name> |