diff options
| author | dding3 <dingding@dingding-ubuntu.sh.intel.com> | 2016-04-29 10:19:51 +0100 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-04-29 10:19:51 +0100 |
| commit | 6d5aeaae264579673bb75d32a8e4cd96aad9cf83 (patch) | |
| tree | 4e17b12c2d30febef42a2dd2f94b2220108c2609 /mllib/src/main | |
| parent | 7226e1906796e1755dcb5c66fe8359f91e443afd (diff) | |
| download | spark-6d5aeaae264579673bb75d32a8e4cd96aad9cf83.tar.gz spark-6d5aeaae264579673bb75d32a8e4cd96aad9cf83.tar.bz2 spark-6d5aeaae264579673bb75d32a8e4cd96aad9cf83.zip | |
[SPARK-14969][MLLIB] Remove duplicate implementation of compute in LogisticGradient
## What changes were proposed in this pull request?
This PR removes duplicate implementation of compute in LogisticGradient class
## How was this patch tested?
unit tests
Author: dding3 <dingding@dingding-ubuntu.sh.intel.com>
Closes #12747 from dding3/master.
Diffstat (limited to 'mllib/src/main')
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala | 7 | ||||
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala | 6 |
2 files changed, 0 insertions, 13 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala b/mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala index 913479f020..3588ac1e95 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala @@ -577,13 +577,6 @@ private[ann] object FeedForwardModel { * @param dataStacker data stacker */ private[ann] class ANNGradient(topology: Topology, dataStacker: DataStacker) extends Gradient { - - override def compute(data: Vector, label: Double, weights: Vector): (Vector, Double) = { - val gradient = Vectors.zeros(weights.size) - val loss = compute(data, label, weights, gradient) - (gradient, loss) - } - override def compute( data: Vector, label: Double, diff --git a/mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala b/mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala index 240baeb5a1..450ed8f22b 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala @@ -146,12 +146,6 @@ class LogisticGradient(numClasses: Int) extends Gradient { def this() = this(2) - override def compute(data: Vector, label: Double, weights: Vector): (Vector, Double) = { - val gradient = Vectors.zeros(weights.size) - val loss = compute(data, label, weights, gradient) - (gradient, loss) - } - override def compute( data: Vector, label: Double, |