diff options
| author | Joseph K. Bradley <joseph@databricks.com> | 2015-11-12 17:03:19 -0800 |
|---|---|---|
| committer | Joseph K. Bradley <joseph@databricks.com> | 2015-11-12 17:03:19 -0800 |
| commit | dcb896fd8cec83483f700ee985c352be61cdf233 (patch) | |
| tree | 42af6acc1a3c9f916aa154b564fd8d548df060c9 /mllib/src/test/scala/org | |
| parent | bc092966f8264c6685b3300461cb79dd6a509ecf (diff) | |
| download | spark-dcb896fd8cec83483f700ee985c352be61cdf233.tar.gz spark-dcb896fd8cec83483f700ee985c352be61cdf233.tar.bz2 spark-dcb896fd8cec83483f700ee985c352be61cdf233.zip | |
[SPARK-11712][ML] Make spark.ml LDAModel be abstract
Per discussion in the initial Pipelines LDA PR [https://github.com/apache/spark/pull/9513], we should make LDAModel abstract and create a LocalLDAModel. This code simplification should be done before the 1.6 release to ensure API compatibility in future releases.
CC feynmanliang mengxr
Author: Joseph K. Bradley <joseph@databricks.com>
Closes #9678 from jkbradley/lda-pipelines-2.
Diffstat (limited to 'mllib/src/test/scala/org')
| -rw-r--r-- | mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala b/mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala index edb927495e..b634d31cc3 100644 --- a/mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala +++ b/mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala @@ -156,7 +156,7 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext { MLTestingUtils.checkCopy(model) - assert(!model.isInstanceOf[DistributedLDAModel]) + assert(model.isInstanceOf[LocalLDAModel]) assert(model.vocabSize === vocabSize) assert(model.estimatedDocConcentration.size === k) assert(model.topicsMatrix.numRows === vocabSize) @@ -210,7 +210,7 @@ class LDASuite extends SparkFunSuite with MLlibTestSparkContext { assert(model.isDistributed) val localModel = model.toLocal - assert(!localModel.isInstanceOf[DistributedLDAModel]) + assert(localModel.isInstanceOf[LocalLDAModel]) // training logLikelihood, logPrior val ll = model.trainingLogLikelihood |