diff options
| author | Vasilis Vryniotis <vvryniotis@hotels.com> | 2017-03-01 20:55:17 +0200 |
|---|---|---|
| committer | Nick Pentreath <nickp@za.ibm.com> | 2017-03-01 20:55:17 +0200 |
| commit | 417140e441505f20eb5bd4943ce216c3ec6adc10 (patch) | |
| tree | d3139ae419d60cd427e1b6361cc23a6ff704ac75 /mllib/src | |
| parent | 8aa560b75e6b083b2a890c52301414285ba35c3d (diff) | |
| download | spark-417140e441505f20eb5bd4943ce216c3ec6adc10.tar.gz spark-417140e441505f20eb5bd4943ce216c3ec6adc10.tar.bz2 spark-417140e441505f20eb5bd4943ce216c3ec6adc10.zip | |
[SPARK-19787][ML] Changing the default parameter of regParam.
## What changes were proposed in this pull request?
In the ALS method the default values of regParam do not match within the same file (lines [224](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224) and [714](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714)). In one place we set it to 1.0 and in the other to 0.1.
I changed the one of train() method to 0.1 and now it matches the default value which is visible to Spark users. The method is marked with DeveloperApi so it should not affect the users. Whenever we use the particular method we provide all parameters, so the default does not matter. Only exception is the unit-tests on ALSSuite but the change does not break them.
Note: This PR should get the award of the laziest commit in Spark history. Originally I wanted to correct this on another PR but MLnick [suggested](https://github.com/apache/spark/pull/17059#issuecomment-283333572) to create a separate PR & ticket. If you think this change is too insignificant/minor, you are probably right, so feel free to reject and close this. :)
## How was this patch tested?
Unit-tests
Author: Vasilis Vryniotis <vvryniotis@hotels.com>
Closes #17121 from datumbox/als_regparam.
Diffstat (limited to 'mllib/src')
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala index af007625d1..04273a40d9 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala @@ -711,7 +711,7 @@ object ALS extends DefaultParamsReadable[ALS] with Logging { numUserBlocks: Int = 10, numItemBlocks: Int = 10, maxIter: Int = 10, - regParam: Double = 1.0, + regParam: Double = 0.1, implicitPrefs: Boolean = false, alpha: Double = 1.0, nonnegative: Boolean = false, |