diff options
| author | Bryan Cutler <cutlerb@gmail.com> | 2017-01-31 15:42:36 -0800 |
|---|---|---|
| committer | Holden Karau <holden@us.ibm.com> | 2017-01-31 15:42:36 -0800 |
| commit | 57d70d26c88819360cdc806e7124aa2cc1b9e4c5 (patch) | |
| tree | 989a46211f9f6e7069dd77a41bf3f805716f863d /mllib/src | |
| parent | ce112cec4f9bff222aa256893f94c316662a2a7e (diff) | |
| download | spark-57d70d26c88819360cdc806e7124aa2cc1b9e4c5.tar.gz spark-57d70d26c88819360cdc806e7124aa2cc1b9e4c5.tar.bz2 spark-57d70d26c88819360cdc806e7124aa2cc1b9e4c5.zip | |
[SPARK-17161][PYSPARK][ML] Add PySpark-ML JavaWrapper convenience function to create Py4J JavaArrays
## What changes were proposed in this pull request?
Adding convenience function to Python `JavaWrapper` so that it is easy to create a Py4J JavaArray that is compatible with current class constructors that have a Scala `Array` as input so that it is not necessary to have a Java/Python friendly constructor. The function takes a Java class as input that is used by Py4J to create the Java array of the given class. As an example, `OneVsRest` has been updated to use this and the alternate constructor is removed.
## How was this patch tested?
Added unit tests for the new convenience function and updated `OneVsRest` doctests which use this to persist the model.
Author: Bryan Cutler <cutlerb@gmail.com>
Closes #14725 from BryanCutler/pyspark-new_java_array-CountVectorizer-SPARK-17161.
Diffstat (limited to 'mllib/src')
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala b/mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala index cbd508ae79..7cbcccf272 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala @@ -135,11 +135,6 @@ final class OneVsRestModel private[ml] ( @Since("1.4.0") val models: Array[_ <: ClassificationModel[_, _]]) extends Model[OneVsRestModel] with OneVsRestParams with MLWritable { - /** A Python-friendly auxiliary constructor. */ - private[ml] def this(uid: String, models: JList[_ <: ClassificationModel[_, _]]) = { - this(uid, Metadata.empty, models.asScala.toArray) - } - /** @group setParam */ @Since("2.1.0") def setFeaturesCol(value: String): this.type = set(featuresCol, value) |