diff options
| author | Wenchen Fan <cloud0fan@outlook.com> | 2015-09-02 11:13:17 -0700 |
|---|---|---|
| committer | Michael Armbrust <michael@databricks.com> | 2015-09-02 11:13:17 -0700 |
| commit | 56c4c172e99a5e14f4bc3308e7ff36d94113b63e (patch) | |
| tree | b0e1c78e2eafccb55524f26a0eff513c2e94c257 /project/MimaExcludes.scala | |
| parent | c3b881a7d7e4736f7131ff002a80e25def1f63af (diff) | |
| download | spark-56c4c172e99a5e14f4bc3308e7ff36d94113b63e.tar.gz spark-56c4c172e99a5e14f4bc3308e7ff36d94113b63e.tar.bz2 spark-56c4c172e99a5e14f4bc3308e7ff36d94113b63e.zip | |
[SPARK-10034] [SQL] add regression test for Sort on Aggregate
Before #8371, there was a bug for `Sort` on `Aggregate` that we can't use aggregate expressions named `_aggOrdering` and can't use more than one ordering expressions which contains aggregate functions. The reason of this bug is that: The aggregate expression in `SortOrder` never get resolved, we alias it with `_aggOrdering` and call `toAttribute` which gives us an `UnresolvedAttribute`. So actually we are referencing aggregate expression by name, not by exprId like we thought. And if there is already an aggregate expression named `_aggOrdering` or there are more than one ordering expressions having aggregate functions, we will have conflict names and can't search by name.
However, after #8371 got merged, the `SortOrder`s are guaranteed to be resolved and we are always referencing aggregate expression by exprId. The Bug doesn't exist anymore and this PR add regression tests for it.
Author: Wenchen Fan <cloud0fan@outlook.com>
Closes #8231 from cloud-fan/sort-agg.
Diffstat (limited to 'project/MimaExcludes.scala')
0 files changed, 0 insertions, 0 deletions