diff options
author | Yanbo Liang <ybliang8@gmail.com> | 2016-03-08 13:27:31 -0800 |
---|---|---|
committer | Joseph K. Bradley <joseph@databricks.com> | 2016-03-08 13:27:31 -0800 |
commit | 9740954f3feb9878cd263feca4aae628e1457f8b (patch) | |
tree | 493f6e294d7e387f035eb1a6beecd95164094ea4 /python/pyspark/sql | |
parent | 46881b4ea229aecbb481626d8b9fbca24c0df075 (diff) | |
download | spark-9740954f3feb9878cd263feca4aae628e1457f8b.tar.gz spark-9740954f3feb9878cd263feca4aae628e1457f8b.tar.bz2 spark-9740954f3feb9878cd263feca4aae628e1457f8b.zip |
[ML] testEstimatorAndModelReadWrite should call checkModelData
## What changes were proposed in this pull request?
Although we defined ```checkModelData``` in [```read/write``` test](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala#L994) of ML estimators/models and pass it to ```testEstimatorAndModelReadWrite```, ```testEstimatorAndModelReadWrite``` omits to call ```checkModelData``` to check the equality of model data. So actually we did not run the check of model data equality for all test cases currently, we should fix it.
BTW, fix the bug of LDA read/write test which did not set ```docConcentration```. This bug should have failed test, but it does not complain because we did not run ```checkModelData``` actually.
cc jkbradley mengxr
## How was this patch tested?
No new unit test, should pass the exist ones.
Author: Yanbo Liang <ybliang8@gmail.com>
Closes #11513 from yanboliang/ml-check-model-data.
Diffstat (limited to 'python/pyspark/sql')
0 files changed, 0 insertions, 0 deletions