diff options
| author | jinxing <jinxing@meituan.com> | 2017-02-19 04:34:07 -0800 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2017-02-19 04:34:07 -0800 |
| commit | ba8912e5f3d5c5a366cb3d1f6be91f2471d048d2 (patch) | |
| tree | 0f8db3d54422c584fb03a492283792fff364e39b /resource-managers/mesos/src | |
| parent | df3cbe3a330f359fbaf7011d7ba9904649d3100d (diff) | |
| download | spark-ba8912e5f3d5c5a366cb3d1f6be91f2471d048d2.tar.gz spark-ba8912e5f3d5c5a366cb3d1f6be91f2471d048d2.tar.bz2 spark-ba8912e5f3d5c5a366cb3d1f6be91f2471d048d2.zip | |
[SPARK-19450] Replace askWithRetry with askSync.
## What changes were proposed in this pull request?
`askSync` is already added in `RpcEndpointRef` (see SPARK-19347 and https://github.com/apache/spark/pull/16690#issuecomment-276850068) and `askWithRetry` is marked as deprecated.
As mentioned SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):
>askWithRetry is basically an unneeded API, and a leftover from the akka days that doesn't make sense anymore. It's prone to cause deadlocks (exactly because it's blocking), it imposes restrictions on the caller (e.g. idempotency) and other things that people generally don't pay that much attention to when using it.
Since `askWithRetry` is just used inside spark and not in user logic. It might make sense to replace all of them with `askSync`.
## How was this patch tested?
This PR doesn't change code logic, existing unit test can cover.
Author: jinxing <jinxing@meituan.com>
Closes #16790 from jinxing64/SPARK-19450.
Diffstat (limited to 'resource-managers/mesos/src')
| -rw-r--r-- | resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala b/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala index a674da4066..cdb3b68489 100644 --- a/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala +++ b/resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala @@ -442,7 +442,7 @@ class MesosCoarseGrainedSchedulerBackendSuite extends SparkFunSuite backend.stop() // Any method of the backend involving sending messages to the driver endpoint should not // be called after the backend is stopped. - verify(driverEndpoint, never()).askWithRetry(isA(classOf[RemoveExecutor]))(any[ClassTag[_]]) + verify(driverEndpoint, never()).askSync(isA(classOf[RemoveExecutor]))(any[ClassTag[_]]) } test("mesos supports spark.executor.uri") { |