diff options
| author | Jonathan Alter <jonalter@users.noreply.github.com> | 2015-07-10 11:34:01 +0100 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2015-07-10 11:34:01 +0100 |
| commit | e14b545d2dcbc4587688b4c46718d3680b0a2f67 (patch) | |
| tree | 8ae5fe8258bce4fd1cb2d55c7031de8b1dcc3963 /scalastyle-config.xml | |
| parent | d538919cc4fd3ab940d478c62dce1bae0270cfeb (diff) | |
| download | spark-e14b545d2dcbc4587688b4c46718d3680b0a2f67.tar.gz spark-e14b545d2dcbc4587688b4c46718d3680b0a2f67.tar.bz2 spark-e14b545d2dcbc4587688b4c46718d3680b0a2f67.zip | |
[SPARK-7977] [BUILD] Disallowing println
Author: Jonathan Alter <jonalter@users.noreply.github.com>
Closes #7093 from jonalter/SPARK-7977 and squashes the following commits:
ccd44cc [Jonathan Alter] Changed println to log in ThreadingSuite
7fcac3e [Jonathan Alter] Reverting to println in ThreadingSuite
10724b6 [Jonathan Alter] Changing some printlns to logs in tests
eeec1e7 [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
0b1dcb4 [Jonathan Alter] More println cleanup
aedaf80 [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
925fd98 [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
0c16fa3 [Jonathan Alter] Replacing some printlns with logs
45c7e05 [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
5c8e283 [Jonathan Alter] Allowing println in audit-release examples
5b50da1 [Jonathan Alter] Allowing printlns in example files
ca4b477 [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
83ab635 [Jonathan Alter] Fixing new printlns
54b131f [Jonathan Alter] Merge branch 'master' of github.com:apache/spark into SPARK-7977
1cd8a81 [Jonathan Alter] Removing some unnecessary comments and printlns
b837c3a [Jonathan Alter] Disallowing println
Diffstat (limited to 'scalastyle-config.xml')
| -rw-r--r-- | scalastyle-config.xml | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/scalastyle-config.xml b/scalastyle-config.xml index d6f927b6fa..4961170379 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -141,12 +141,8 @@ This file is divided into 3 sections: <customMessage>Tests must extend org.apache.spark.SparkFunSuite instead.</customMessage> </check> - <!-- ================================================================================ --> - <!-- rules we'd like to enforce, but haven't cleaned up the codebase yet --> - <!-- ================================================================================ --> - - <!-- SPARK-7977 We should turn this on, but we'd need to add whitelist to files that are using it first. --> - <check customId="println" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="false"> + <!-- As of SPARK-7977 all printlns need to be wrapped in '// scalastyle:off/on println' --> + <check customId="println" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true"> <parameters><parameter name="regex">^println$</parameter></parameters> <customMessage><![CDATA[Are you sure you want to println? If yes, wrap the code block with // scalastyle:off println @@ -154,6 +150,10 @@ This file is divided into 3 sections: // scalastyle:on println]]></customMessage> </check> + <!-- ================================================================================ --> + <!-- rules we'd like to enforce, but haven't cleaned up the codebase yet --> + <!-- ================================================================================ --> + <!-- We cannot turn the following two on, because it'd fail a lot of string interpolation use cases. --> <!-- Ideally the following two rules should be configurable to rule out string interpolation. --> <check level="error" class="org.scalastyle.scalariform.NoWhitespaceBeforeLeftBracketChecker" enabled="false"></check> |