aboutsummaryrefslogtreecommitdiff
path: root/sql
diff options
context:
space:
mode:
authorLiang-Chi Hsieh <viirya@gmail.com>2015-04-22 22:18:56 -0700
committerTathagata Das <tathagata.das1565@gmail.com>2015-04-22 22:18:56 -0700
commitd9e70f331fc3999d615ede49fc69a993dc65f272 (patch)
tree9630e8a4129ea9167f087b79fed316b74f9052b1 /sql
parent03e85b4a11899f37424cd6e1f8d71f1d704c90bb (diff)
downloadspark-d9e70f331fc3999d615ede49fc69a993dc65f272.tar.gz
spark-d9e70f331fc3999d615ede49fc69a993dc65f272.tar.bz2
spark-d9e70f331fc3999d615ede49fc69a993dc65f272.zip
[HOTFIX][SQL] Fix broken cached test
Added in #5475. Pointed as broken in #5639. /cc marmbrus Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #5640 from viirya/fix_cached_test and squashes the following commits: c0cf69a [Liang-Chi Hsieh] Fix broken cached test.
Diffstat (limited to 'sql')
-rw-r--r--sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala21
1 files changed, 14 insertions, 7 deletions
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
index 01e3b86710..0772e5e187 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
@@ -300,19 +300,26 @@ class CachedTableSuite extends QueryTest {
}
test("Clear accumulators when uncacheTable to prevent memory leaking") {
- val accsSize = Accumulators.originals.size
-
sql("SELECT key FROM testData LIMIT 10").registerTempTable("t1")
sql("SELECT key FROM testData LIMIT 5").registerTempTable("t2")
- cacheTable("t1")
- cacheTable("t2")
+
+ Accumulators.synchronized {
+ val accsSize = Accumulators.originals.size
+ cacheTable("t1")
+ cacheTable("t2")
+ assert((accsSize + 2) == Accumulators.originals.size)
+ }
+
sql("SELECT * FROM t1").count()
sql("SELECT * FROM t2").count()
sql("SELECT * FROM t1").count()
sql("SELECT * FROM t2").count()
- uncacheTable("t1")
- uncacheTable("t2")
- assert(accsSize >= Accumulators.originals.size)
+ Accumulators.synchronized {
+ val accsSize = Accumulators.originals.size
+ uncacheTable("t1")
+ uncacheTable("t2")
+ assert((accsSize - 2) == Accumulators.originals.size)
+ }
}
}