aboutsummaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorPrashant Sharma <prashant@apache.org>2014-09-15 21:14:00 -0700
committerReynold Xin <rxin@apache.org>2014-09-15 21:14:00 -0700
commitecf0c02935815f0d4018c0e30ec4c784e60a5db0 (patch)
tree67c6932a37eeb0b8fecb8566a73efd4c3b98c59e /tools
parentd428ac6a221d2dce19c43442abf197f2ade6658f (diff)
downloadspark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.tar.gz
spark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.tar.bz2
spark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.zip
[SPARK-3433][BUILD] Fix for Mima false-positives with @DeveloperAPI and @Experimental annotations.
Actually false positive reported was due to mima generator not picking up the new jars in presence of old jars(theoretically this should not have happened.). So as a workaround, ran them both separately and just append them together. Author: Prashant Sharma <prashant@apache.org> Author: Prashant Sharma <prashant.s@imaginea.com> Closes #2285 from ScrapCodes/mima-fix and squashes the following commits: 093c76f [Prashant Sharma] Update mima 59012a8 [Prashant Sharma] Update mima 35b6c71 [Prashant Sharma] SPARK-3433 Fix for Mima false-positives with @DeveloperAPI and @Experimental annotations.
Diffstat (limited to 'tools')
-rw-r--r--tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala14
1 files changed, 10 insertions, 4 deletions
diff --git a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
index bcf6d43ab3..595ded6ae6 100644
--- a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
+++ b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
@@ -24,6 +24,7 @@ import scala.collection.mutable
import scala.collection.JavaConversions._
import scala.reflect.runtime.universe.runtimeMirror
import scala.reflect.runtime.{universe => unv}
+import scala.util.Try
/**
* A tool for generating classes to be excluded during binary checking with MIMA. It is expected
@@ -121,12 +122,17 @@ object GenerateMIMAIgnore {
}
def main(args: Array[String]) {
+ import scala.tools.nsc.io.File
val (privateClasses, privateMembers) = privateWithin("org.apache.spark")
- scala.tools.nsc.io.File(".generated-mima-class-excludes").
- writeAll(privateClasses.mkString("\n"))
+ val previousContents = Try(File(".generated-mima-class-excludes").lines()).
+ getOrElse(Iterator.empty).mkString("\n")
+ File(".generated-mima-class-excludes")
+ .writeAll(previousContents + privateClasses.mkString("\n"))
println("Created : .generated-mima-class-excludes in current directory.")
- scala.tools.nsc.io.File(".generated-mima-member-excludes").
- writeAll(privateMembers.mkString("\n"))
+ val previousMembersContents = Try(File(".generated-mima-member-excludes").lines)
+ .getOrElse(Iterator.empty).mkString("\n")
+ File(".generated-mima-member-excludes").writeAll(previousMembersContents +
+ privateMembers.mkString("\n"))
println("Created : .generated-mima-member-excludes in current directory.")
}