diff options
| author | Josh Rosen <joshrosen@databricks.com> | 2015-04-30 15:21:00 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2015-04-30 15:21:00 -0700 |
| commit | 07a86205f9efc43ea1ec5edb97c21c32abe7fb8a (patch) | |
| tree | 1d86ed6ad23411f332668e16e969d755e7d40f0b /unsafe/pom.xml | |
| parent | 6702324b60f99dab55912c08ccd3d03805f6b7b2 (diff) | |
| download | spark-07a86205f9efc43ea1ec5edb97c21c32abe7fb8a.tar.gz spark-07a86205f9efc43ea1ec5edb97c21c32abe7fb8a.tar.bz2 spark-07a86205f9efc43ea1ec5edb97c21c32abe7fb8a.zip | |
[SPARK-7288] Suppress compiler warnings due to use of sun.misc.Unsafe; add facade in front of Unsafe; remove use of Unsafe.setMemory
This patch suppresses compiler warnings due to our use of `sun.misc.Unsafe` (introduced in #5725). These warnings can only be suppressed via the `-XDignore.symbol.file` javac flag; the `SuppressWarnings` annotation won't work for these.
In order to restrict uses of this compiler flag to the `unsafe` module, I placed a facade in front of `Unsafe` so that other modules won't call it directly. This facade also will also help us to avoid accidental usage of deprecated Unsafe methods or methods that aren't supported in Java 6.
I also removed an unnecessary use of `Unsafe.setMemory`, which isn't present in certain versions of Java 6, and excluded the new `unsafe` module from Javadoc.
Author: Josh Rosen <joshrosen@databricks.com>
Closes #5814 from JoshRosen/unsafe-compiler-warnings-fixes and squashes the following commits:
9e8c483 [Josh Rosen] Exclude new unsafe module from Javadoc
ba75ecf [Josh Rosen] Only apply -XDignore.symbol.file flag in unsafe project.
7403345 [Josh Rosen] Put facade in front of Unsafe.
50230c0 [Josh Rosen] Remove usage of Unsafe.setMemory
96d41c9 [Josh Rosen] Use -XDignore.symbol.file to suppress warnings about sun.misc.Unsafe usage
Diffstat (limited to 'unsafe/pom.xml')
| -rw-r--r-- | unsafe/pom.xml | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/unsafe/pom.xml b/unsafe/pom.xml index 8901d77591..5b0733206b 100644 --- a/unsafe/pom.xml +++ b/unsafe/pom.xml @@ -65,5 +65,29 @@ <build> <outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory> <testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory> + <pluginManagement> + <plugins> + <plugin> + <groupId>net.alchim31.maven</groupId> + <artifactId>scala-maven-plugin</artifactId> + <configuration> + <javacArgs> + <!-- This option is needed to suppress warnings from sun.misc.Unsafe usage --> + <javacArg>-XDignore.symbol.file</javacArg> + </javacArgs> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <configuration> + <compilerArgs> + <!-- This option is needed to suppress warnings from sun.misc.Unsafe usage --> + <arg>-XDignore.symbol.file</arg> + </compilerArgs> + </configuration> + </plugin> + </plugins> + </pluginManagement> </build> </project> |