1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.spark.util
import org.scalatest.FunSuite
import org.apache.spark.LocalSparkContext._
import org.apache.spark.SparkContext
class ClosureCleanerSuite extends FunSuite {
test("closures inside an object") {
assert(TestObject.run() === 30) // 6 + 7 + 8 + 9
}
test("closures inside a class") {
val obj = new TestClass
assert(obj.run() === 30) // 6 + 7 + 8 + 9
}
test("closures inside a class with no default constructor") {
val obj = new TestClassWithoutDefaultConstructor(5)
assert(obj.run() === 30) // 6 + 7 + 8 + 9
}
test("closures that don't use fields of the outer class") {
val obj = new TestClassWithoutFieldAccess
assert(obj.run() === 30) // 6 + 7 + 8 + 9
}
test("nested closures inside an object") {
assert(TestObjectWithNesting.run() === 96) // 4 * (1+2+3+4) + 4 * (1+2+3+4) + 16 * 1
}
test("nested closures inside a class") {
val obj = new TestClassWithNesting(1)
assert(obj.run() === 96) // 4 * (1+2+3+4) + 4 * (1+2+3+4) + 16 * 1
}
test("capturing free variables in closures at RDD definition") {
val obj = new TestCaptureVarClass()
val (ones, onesPlusZeroes) = obj.run()
assert(ones === onesPlusZeroes)
}
test("capturing free variable fields in closures at RDD definition") {
val obj = new TestCaptureFieldClass()
val (ones, onesPlusZeroes) = obj.run()
assert(ones === onesPlusZeroes)
}
test("capturing arrays in closures at RDD definition") {
val obj = new TestCaptureArrayEltClass()
val (observed, expected) = obj.run()
assert(observed === expected)
}
}
// A non-serializable class we create in closures to make sure that we aren't
// keeping references to unneeded variables from our outer closures.
class NonSerializable {}
object TestObject {
def run(): Int = {
var nonSer = new NonSerializable
val x = 5
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
nums.map(_ + x).reduce(_ + _)
}
}
}
class TestClass extends Serializable {
var x = 5
def getX = x
def run(): Int = {
var nonSer = new NonSerializable
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
nums.map(_ + getX).reduce(_ + _)
}
}
}
class TestClassWithoutDefaultConstructor(x: Int) extends Serializable {
def getX = x
def run(): Int = {
var nonSer = new NonSerializable
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
nums.map(_ + getX).reduce(_ + _)
}
}
}
// This class is not serializable, but we aren't using any of its fields in our
// closures, so they won't have a $outer pointing to it and should still work.
class TestClassWithoutFieldAccess {
var nonSer = new NonSerializable
def run(): Int = {
var nonSer2 = new NonSerializable
var x = 5
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
nums.map(_ + x).reduce(_ + _)
}
}
}
object TestObjectWithNesting {
def run(): Int = {
var nonSer = new NonSerializable
var answer = 0
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
var y = 1
for (i <- 1 to 4) {
var nonSer2 = new NonSerializable
var x = i
answer += nums.map(_ + x + y).reduce(_ + _)
}
answer
}
}
}
class TestClassWithNesting(val y: Int) extends Serializable {
def getY = y
def run(): Int = {
var nonSer = new NonSerializable
var answer = 0
withSpark(new SparkContext("local", "test")) { sc =>
val nums = sc.parallelize(Array(1, 2, 3, 4))
for (i <- 1 to 4) {
var nonSer2 = new NonSerializable
var x = i
answer += nums.map(_ + x + getY).reduce(_ + _)
}
answer
}
}
}
class TestCaptureFieldClass extends Serializable {
class ZeroBox extends Serializable {
var zero = 0
}
def run(): (Int, Int) = {
val zb = new ZeroBox
withSpark(new SparkContext("local", "test")) {sc =>
val ones = sc.parallelize(Array(1, 1, 1, 1, 1))
val onesPlusZeroes = ones.map(_ + zb.zero)
zb.zero = 5
(ones.reduce(_ + _), onesPlusZeroes.reduce(_ + _))
}
}
}
class TestCaptureArrayEltClass extends Serializable {
def run(): (Int, Int) = {
withSpark(new SparkContext("local", "test")) {sc =>
val rdd = sc.parallelize(1 to 10)
val data = Array(1, 2, 3)
val expected = data(0)
val mapped = rdd.map(x => data(0))
data(0) = 4
(mapped.first, expected)
}
}
}
class TestCaptureVarClass extends Serializable {
def run(): (Int, Int) = {
var zero = 0
withSpark(new SparkContext("local", "test")) {sc =>
val ones = sc.parallelize(Array(1, 1, 1, 1, 1))
val onesPlusZeroes = ones.map(_ + zero)
zero = 5
(ones.reduce(_ + _), onesPlusZeroes.reduce(_ + _))
}
}
}
|
