diff options
author | Luciano Resende <lresende@apache.org> | 2017-01-18 15:51:49 -0800 |
---|---|---|
committer | Luciano Resende <lresende@apache.org> | 2017-01-18 15:51:49 -0800 |
commit | 1a19ba5bba00dd897081396edd448b2bfd316fd0 (patch) | |
tree | cd4efb287ee962b8bc14f49c5247d8614e67ea20 | |
parent | fd702c52e9bfdf08cccea7479891ea2786c27ee1 (diff) | |
download | toree-gateway-1a19ba5bba00dd897081396edd448b2bfd316fd0.tar.gz toree-gateway-1a19ba5bba00dd897081396edd448b2bfd316fd0.tar.bz2 toree-gateway-1a19ba5bba00dd897081396edd448b2bfd316fd0.zip |
Avoid completing the promise when result is not called yet
-rw-r--r-- | src/main/scala/com/ibm/ToreeGateway.scala | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/src/main/scala/com/ibm/ToreeGateway.scala b/src/main/scala/com/ibm/ToreeGateway.scala index e002ecb..3d47350 100644 --- a/src/main/scala/com/ibm/ToreeGateway.scala +++ b/src/main/scala/com/ibm/ToreeGateway.scala @@ -37,27 +37,30 @@ import scala.util.Try class ToreeGateway(client: SparkKernelClient) { final val log = LoggerFactory.getLogger(this.getClass.getName.stripSuffix("$")) + private def handleResult(promise:Promise[String], result: ExecuteResult) = { - log.warn(s"Result was: ${result.data(MIMEType.PlainText)}") + log.info(s"Result was: ${result.data(MIMEType.PlainText)}") promise.success(result.data(MIMEType.PlainText)) //promise.success(result.content) } private def handleSuccess(promise:Promise[String], executeReplyOk: ExecuteReplyOk) = { + /* if(! promise.isCompleted) { - log.warn(s"Successful code completion") + log.info(s"Successful code completion") promise.complete(Try("done")) } + */ } private def handleError(promise:Promise[String], reply:ExecuteReplyError) { - log.warn(s"Error was: ${reply.ename.get}") + log.info(s"Error was: ${reply.ename.get}") //promise.failure(new Throwable("Error evaluating paragraph: " + reply.content)) promise.success(reply.status + ":" + reply.ename.getOrElse("") + " - " + reply.evalue.getOrElse("")) } private def handleStream(promise:Promise[String], content: StreamContent) { - log.warn(s"Received streaming content ${content.name} was: ${content.text}") + log.info(s"Received streaming content ${content.name} was: ${content.text}") promise.success(content.text) } @@ -104,19 +107,16 @@ object ToreeGatewayClient extends App { filePath } - log.info("Application Initialized from " + new java.io.File(".").getCanonicalPath) - log.info("With the following parameters:" ) - if (args.length == 0 ) { - log.info(">>> NONE" ) - } else { - for (arg <- args) { - log.info(">>> Arg :" + arg ) - } + if (log.isDebugEnabled ) { + log.debug("Application Initialized from " + new java.io.File(".").getCanonicalPath) + log.debug("With the following parameters:" ) } // Parse our configuration and create a client connecting to our kernel val configFileContent = scala.io.Source.fromFile(getConfigurationFilePath).mkString - log.info(">>> Configuration in use " + configFileContent) + if (log.isDebugEnabled()) { + log.debug(">>> Configuration in use " + configFileContent) + } val config: Config = ConfigFactory.parseString(configFileContent) val client = (new ClientBootstrap(config) |