aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJean Cyr <jcyr@dillobits.com>2014-07-26 09:05:44 -0400
committerJean Cyr <jcyr@dillobits.com>2014-07-26 09:05:44 -0400
commit3a4da7c5fa827970a86777ee6f4dc201246f0d0d (patch)
tree649a060e46b15b2d43ac8691eb7e7bc9921009a3
parent2de38d0628f3146caea28cd42b30840241269f41 (diff)
downloadpx4-firmware-3a4da7c5fa827970a86777ee6f4dc201246f0d0d.tar.gz
px4-firmware-3a4da7c5fa827970a86777ee6f4dc201246f0d0d.tar.bz2
px4-firmware-3a4da7c5fa827970a86777ee6f4dc201246f0d0d.zip
Revert to original loop
Original loop was correct, and slightly more efficient. Retain initialization of ret to handle the case where passed in count is 0.
-rw-r--r--src/drivers/px4io/px4io_uploader.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/drivers/px4io/px4io_uploader.cpp b/src/drivers/px4io/px4io_uploader.cpp
index 986e39dc8..fb16f891f 100644
--- a/src/drivers/px4io/px4io_uploader.cpp
+++ b/src/drivers/px4io/px4io_uploader.cpp
@@ -274,12 +274,11 @@ int
PX4IO_Uploader::recv_bytes(uint8_t *p, unsigned count)
{
int ret = OK;
- while (count) {
+ while (count--) {
ret = recv_byte_with_timeout(p++, 5000);
if (ret != OK)
break;
- count--;
}
return ret;
}